diff options
| author | Keyhan Vakil <kvakil@sylph.kvakil.me> | 2023-03-15 23:55:19 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-16 06:55:19 +0000 |
| commit | 8713c83462df192dbf319e4ac0c2640b3a8cfff7 (patch) | |
| tree | 1b733e93a5f53ac737809ef9a01ab6dc3a0ec24f /src | |
| parent | 2566400aa27f401c0d85556aaf024e3601adce21 (diff) | |
| download | node-new-8713c83462df192dbf319e4ac0c2640b3a8cfff7.tar.gz | |
src: remove dead comments about return_code_cache
This behavior of sometimes returning the function & other times
returning the code cache was removed a long time ago in the referenced
PR, as evinced by the return type `MaybeLocal<Function>`. Remove these
incorrect comments.
Refs: https://github.com/nodejs/node/pull/24950
PR-URL: https://github.com/nodejs/node/pull/47083
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_builtins.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/node_builtins.cc b/src/node_builtins.cc index 0439fff511..e2097a07bf 100644 --- a/src/node_builtins.cc +++ b/src/node_builtins.cc @@ -253,9 +253,6 @@ bool BuiltinLoader::Add(const char* id, std::string_view utf8source) { return Add(id, UnionBytes(out)); } -// Returns Local<Function> of the compiled module if return_code_cache -// is false (we are only compiling the function). -// Otherwise return a Local<Object> containing the cache. MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal( Local<Context> context, const char* id, @@ -353,9 +350,6 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal( return scope.Escape(fun); } -// Returns Local<Function> of the compiled module if return_code_cache -// is false (we are only compiling the function). -// Otherwise return a Local<Object> containing the cache. MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context, const char* id, Realm* optional_realm) { |