diff options
author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2016-09-28 20:14:23 +0200 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2016-10-06 10:27:30 -0700 |
commit | fdca79fbc0a797206fa690d51b8844ed4fd596d6 (patch) | |
tree | 868cff27a76b16595ef6b832140a6f7ccd8dcd1d /test/addons/async-hello-world/test.js | |
parent | 47d1588e7562b0476715c40c4c323edc30308cae (diff) | |
download | node-new-fdca79fbc0a797206fa690d51b8844ed4fd596d6.tar.gz |
test: enable addons test to pass with debug build
Currently when running configure with the --debug option in combination
with the tests (./configure --debug && make -j8 test) there are a few
addon tests that fail with error messages similar to this:
=== release test ===
Path: addons/load-long-path/test
fs.js:558
return binding.open(pathModule._makeLong(path), stringToFlags(flags),
mode);
^
Error: ENOENT: no such file or directory, open
'/nodejs/node/test/addons/load-long-path/build/Release/binding.node'
at Object.fs.openSync (fs.js:558:18)
at Object.fs.readFileSync (fs.js:468:33)
at Object.<anonymous>
(/nodejs/node/test/addons/load-long-path/test.js:28:19)
at Module._compile (module.js:560:32)
at Object.Module._extensions..js (module.js:569:10)
at Module.load (module.js:477:32)
at tryModuleLoad (module.js:436:12)
at Function.Module._load (module.js:428:3)
at Module.runMain (module.js:594:10)
at run (bootstrap_node.js:382:7)
Command: out/Release/node
/nodejs/node/test/addons/load-long-path/test.js
This commit allows for the tests to pass even if the configured build
type is of type debug.
PR-URL: https://github.com/nodejs/node/pull/8836
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/addons/async-hello-world/test.js')
-rw-r--r-- | test/addons/async-hello-world/test.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/addons/async-hello-world/test.js b/test/addons/async-hello-world/test.js index 2ed003e444..bbc81bfbf8 100644 --- a/test/addons/async-hello-world/test.js +++ b/test/addons/async-hello-world/test.js @@ -1,7 +1,7 @@ 'use strict'; const common = require('../../common'); var assert = require('assert'); -var binding = require('./build/Release/binding'); +const binding = require(`./build/${common.buildType}/binding`); binding(5, common.mustCall(function(err, val) { assert.equal(null, err); |