diff options
author | Anatoli Papirovski <apapirovski@mac.com> | 2018-01-19 15:42:59 -0500 |
---|---|---|
committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-01-29 11:37:29 -0500 |
commit | eeede3b19c8bdb78605764eec75bea327c9014ff (patch) | |
tree | f57709e12c4e7e9562951bb07042f0023925a441 /test/addons/repl-domain-abort/test.js | |
parent | e4743ab61929bcccc729165e74eb6d6b3ef25135 (diff) | |
download | node-new-eeede3b19c8bdb78605764eec75bea327c9014ff.tar.gz |
domain: further abstract usage in C++
Move the majority of C++ domain-related code into JS land by introducing
a top level domain callback which handles entering & exiting the domain.
Move the rest of the domain necessities into their own file that creates
an internal binding, to avoid exposing domain-related code on the
process object.
Modify an existing test slightly to better test domain-related code.
PR-URL: https://github.com/nodejs/node/pull/18291
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/addons/repl-domain-abort/test.js')
-rw-r--r-- | test/addons/repl-domain-abort/test.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/addons/repl-domain-abort/test.js b/test/addons/repl-domain-abort/test.js index 1d6116159c..2049fe6e6a 100644 --- a/test/addons/repl-domain-abort/test.js +++ b/test/addons/repl-domain-abort/test.js @@ -40,7 +40,8 @@ const lines = [ // This line shouldn't cause an assertion error. `require('${buildPath}')` + // Log output to double check callback ran. - '.method(function() { console.log(\'cb_ran\'); });', + '.method(function(v1, v2) {' + + 'console.log(\'cb_ran\'); return v1 === true && v2 === false; });', ]; const dInput = new stream.Readable(); |