diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-10-03 23:29:41 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2020-10-11 02:20:53 +0200 |
| commit | 278d38f4cf3d2821984660b4de73f8d414db17c7 (patch) | |
| tree | 60aef3854353c414d8371b6ac613debcba49585f /test/embedding | |
| parent | 275153ddc4fe0e49d5f73807edaa6eca0c3041cb (diff) | |
| download | node-new-278d38f4cf3d2821984660b4de73f8d414db17c7.tar.gz | |
src: add maybe versions of EmitExit and EmitBeforeExit
This addresses a TODO comment, and removes invalid `.ToLocalChecked()`
calls from our code base.
PR-URL: https://github.com/nodejs/node/pull/35486
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/embedding')
| -rw-r--r-- | test/embedding/embedtest.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/test/embedding/embedtest.cc b/test/embedding/embedtest.cc index 21baadf93e..fece8924ad 100644 --- a/test/embedding/embedtest.cc +++ b/test/embedding/embedtest.cc @@ -110,12 +110,14 @@ int RunNodeInstance(MultiIsolatePlatform* platform, more = uv_loop_alive(&loop); if (more) continue; - node::EmitBeforeExit(env.get()); + if (node::EmitProcessBeforeExit(env.get()).IsNothing()) + break; + more = uv_loop_alive(&loop); } while (more == true); } - exit_code = node::EmitExit(env.get()); + exit_code = node::EmitProcessExit(env.get()).FromMaybe(1); node::Stop(env.get()); } |