diff options
| author | Brian White <mscdex@mscdex.net> | 2017-05-27 20:32:17 -0400 |
|---|---|---|
| committer | Brian White <mscdex@mscdex.net> | 2017-06-01 21:59:57 -0400 |
| commit | 8d7ff6dd7561c7c8012466542ecabec2a5bc106d (patch) | |
| tree | 95bfad29edf825c2a0c91cc84459d15870ecd5e2 /test/internet | |
| parent | 95eef9b0440320694cd6a8ef9e30eb185e77824e (diff) | |
| download | node-new-8d7ff6dd7561c7c8012466542ecabec2a5bc106d.tar.gz | |
test: improve dns internet test case
0.0.0.0 is more common than other special ipv4 addresses, so
it is possible that we may not get ENOTFOUND for such addresses.
Instead, this commit uses a less common address that is reserved
for documentation (RFC) use only.
PR-URL: https://github.com/nodejs/node/pull/13261
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/internet')
| -rw-r--r-- | test/internet/test-dns.js | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js index fc001ff965..3096fda5b1 100644 --- a/test/internet/test-dns.js +++ b/test/internet/test-dns.js @@ -492,11 +492,12 @@ TEST(function test_lookupservice_invalid(done) { TEST(function test_reverse_failure(done) { - const req = dns.reverse('0.0.0.0', function(err) { + // 203.0.113.0/24 are addresses reserved for (RFC) documentation use only + const req = dns.reverse('203.0.113.0', function(err) { assert(err instanceof Error); assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code... - assert.strictEqual(err.hostname, '0.0.0.0'); - assert.ok(/0\.0\.0\.0/.test(err.message)); + assert.strictEqual(err.hostname, '203.0.113.0'); + assert.ok(/203\.0\.113\.0/.test(err.message)); done(); }); |