diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-05-18 06:50:14 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2020-05-23 17:45:42 +0200 |
| commit | b18d8dde847e1bff188c6cfb2d65a96209146c2c (patch) | |
| tree | 1c33882dfbdeeb7fadebbac62a5d84bb20d6b9fc /test/node-api/test_threadsafe_function/test.js | |
| parent | f14229e7040b376b4934f8d0c98520bb3ed798fc (diff) | |
| download | node-new-b18d8dde847e1bff188c6cfb2d65a96209146c2c.tar.gz | |
Revert "n-api: detect deadlocks in thread-safe function"
This reverts commit d26ca06c16f497ffa5ac4845a27922d5058a9318 because
it breaks running the tests in debug mode, as
`v8::Isolate::GetCurrent()` is not allowed if no `Isolate` is active
on the current thread.
Refs: https://github.com/nodejs/node/pull/33276
Refs: https://github.com/nodejs/node/pull/32860
PR-URL: https://github.com/nodejs/node/pull/33453
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Diffstat (limited to 'test/node-api/test_threadsafe_function/test.js')
| -rw-r--r-- | test/node-api/test_threadsafe_function/test.js | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/test/node-api/test_threadsafe_function/test.js b/test/node-api/test_threadsafe_function/test.js index f5afe225f0..3603d79ee6 100644 --- a/test/node-api/test_threadsafe_function/test.js +++ b/test/node-api/test_threadsafe_function/test.js @@ -210,13 +210,8 @@ new Promise(function testWithoutJSMarshaller(resolve) { })) .then((result) => assert.strictEqual(result.indexOf(0), -1)) -// Start a child process to test rapid teardown. +// Start a child process to test rapid teardown .then(() => testUnref(binding.MAX_QUEUE_SIZE)) -// Start a child process with an infinite queue to test rapid teardown. -.then(() => testUnref(0)) - -// Test deadlock prevention. -.then(() => assert.deepStrictEqual(binding.TestDeadlock(), { - deadlockTest: 'Main thread would deadlock' -})); +// Start a child process with an infinite queue to test rapid teardown +.then(() => testUnref(0)); |