diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-04-28 04:53:52 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2020-04-30 04:56:11 +0200 |
| commit | 8698dd98bbc53ca8da90697e6fbd04a0d04a9580 (patch) | |
| tree | d1cea29a048430c1a73facb2f5982d17a487c2d8 /test/node-api | |
| parent | ff38ec0471f075e3f9c08ac5b803649f6e7e4ac2 (diff) | |
| download | node-new-8698dd98bbc53ca8da90697e6fbd04a0d04a9580.tar.gz | |
test: fix out-of-bound reads from invalid sizeof usage
`sizeof(data)` does not return the correct result here, as it measures
the size of the `data` variable, not what it points to.
PR-URL: https://github.com/nodejs/node/pull/33115
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/node-api')
| -rw-r--r-- | test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c b/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c index 3275551aee..b4f2e288ec 100644 --- a/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c +++ b/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c @@ -35,7 +35,7 @@ NAPI_MODULE_INIT() { NAPI_CALL(env, napi_create_external_arraybuffer( env, data, - sizeof(data), + sizeof(char), finalize_cb, NULL, &buffer)); |