diff options
| author | Sebastian Plesciuc <sebastian.plesciuc@sendgrid.com> | 2017-04-17 18:18:41 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-04-19 10:20:03 -0700 |
| commit | 86a3ba0c4eb4b5226e805d1bc496b567be2e5664 (patch) | |
| tree | 497c2422a4b1f6e6b884620a46f5e33c1ecb3639 /test/parallel/test-cluster-worker-wait-server-close.js | |
| parent | 9c5c4697b57c6455b313b9c3a58d8691ba070c1d (diff) | |
| download | node-new-86a3ba0c4eb4b5226e805d1bc496b567be2e5664.tar.gz | |
test: dynamic port in cluster worker wait close
Remove common.PORT from test-cluster-worker-wait-server-close
possibility that a dynamic port used in another test will collide
with common.PORT.
PR-URL: https://github.com/nodejs/node/pull/12466
Ref: https://github.com/nodejs/node/issues/12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Diffstat (limited to 'test/parallel/test-cluster-worker-wait-server-close.js')
| -rw-r--r-- | test/parallel/test-cluster-worker-wait-server-close.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/parallel/test-cluster-worker-wait-server-close.js b/test/parallel/test-cluster-worker-wait-server-close.js index 7a0e5130f6..a563d52beb 100644 --- a/test/parallel/test-cluster-worker-wait-server-close.js +++ b/test/parallel/test-cluster-worker-wait-server-close.js @@ -12,7 +12,7 @@ if (cluster.isWorker) { // Wait for any data, then close connection socket.write('.'); socket.on('data', common.noop); - }).listen(common.PORT, common.localhostIPv4); + }).listen(0, common.localhostIPv4); server.once('close', function() { serverClosed = true; @@ -33,8 +33,8 @@ if (cluster.isWorker) { const worker = cluster.fork(); // Disconnect worker when it is ready - worker.once('listening', function() { - const socket = net.createConnection(common.PORT, common.localhostIPv4); + worker.once('listening', function(address) { + const socket = net.createConnection(address.port, common.localhostIPv4); socket.on('connect', function() { socket.on('data', function() { |