summaryrefslogtreecommitdiff
path: root/test/parallel/test-dgram-send-bad-arguments.js
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2019-06-08 08:48:05 -0400
committercjihrig <cjihrig@gmail.com>2019-06-10 09:14:13 -0700
commitd1dd4e10db5cb163f265a1abd1f5952f60a81e09 (patch)
tree4bede0f5121354b67b2954290ee0091eb3ac1c89 /test/parallel/test-dgram-send-bad-arguments.js
parentbcf11356b3d8a39a0d731164bee9b2acd4c10bae (diff)
downloadnode-new-d1dd4e10db5cb163f265a1abd1f5952f60a81e09.tar.gz
dgram: fix abort on bad args
This commit fixes a C++ abort for connected dgram sockets by improving input validation in the JS layer. Fixes: https://github.com/nodejs/node/issues/28126 PR-URL: https://github.com/nodejs/node/pull/28135 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-dgram-send-bad-arguments.js')
-rw-r--r--test/parallel/test-dgram-send-bad-arguments.js9
1 files changed, 9 insertions, 0 deletions
diff --git a/test/parallel/test-dgram-send-bad-arguments.js b/test/parallel/test-dgram-send-bad-arguments.js
index 467efbb7b9..f8f2a2de13 100644
--- a/test/parallel/test-dgram-send-bad-arguments.js
+++ b/test/parallel/test-dgram-send-bad-arguments.js
@@ -68,6 +68,15 @@ function checkArgs(connected) {
message: 'Already connected'
}
);
+
+ common.expectsError(
+ () => { sock.send(buf, 1234, '127.0.0.1', common.mustNotCall()); },
+ {
+ code: 'ERR_SOCKET_DGRAM_IS_CONNECTED',
+ type: Error,
+ message: 'Already connected'
+ }
+ );
} else {
assert.throws(() => { sock.send(buf, 1, 1, -1, host); }, RangeError);
assert.throws(() => { sock.send(buf, 1, 1, 0, host); }, RangeError);