test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 5 insertions, 4 deletions

diff --git a/test/parallel/test-domain-http-server.js b/test/parallel/test-domain-http-server.js
index 594c34aae8..e131e02ea4 100644
--- a/test/parallel/test-domain-http-server.js
+++ b/test/parallel/test-domain-http-server.js
@@ -1,8 +1,8 @@
 'use strict';
+require('../common');
 var domain = require('domain');
 var http = require('http');
 var assert = require('assert');
-var common = require('../common');
 
 var objects = { foo: 'bar', baz: {}, num: 42, arr: [1, 2, 3] };
 objects.baz.asdf = objects;
@@ -37,10 +37,11 @@ var server = http.createServer(function(req, res) {
   });
 });
 
-server.listen(common.PORT, next);
+server.listen(0, next);
 
 function next() {
-  console.log('listening on localhost:%d', common.PORT);
+  const port = this.address().port;
+  console.log('listening on localhost:%d', port);
 
   var requests = 0;
   var responses = 0;
@@ -61,7 +62,7 @@ function next() {
       req.socket.destroy();
     });
 
-    var req = http.get({ host: 'localhost', port: common.PORT, path: p });
+    var req = http.get({ host: 'localhost', port: port, path: p });
     dom.add(req);
     req.on('response', function(res) {
       responses++;