diff options
author | Santiago Gimeno <santiago.gimeno@gmail.com> | 2015-12-20 13:21:35 +0100 |
---|---|---|
committer | Julien Gilli <julien.gilli@joyent.com> | 2015-12-23 10:02:29 -0800 |
commit | cf503052bf1cffbb955d643ebcb9bb5d99d64330 (patch) | |
tree | 2cd6d8cca5fccad8d9f548f02662b93fc8de6a5f /test/parallel/test-domain-top-level-error-handler-throw.js | |
parent | 7fac47c94ae2d05b20daeeff714044c974a4d74f (diff) | |
download | node-new-cf503052bf1cffbb955d643ebcb9bb5d99d64330.tar.gz |
test: fix domain-top-level-error-handler-throw
Check the stderr output in the `close` event as it's not guaranteed to
be fully available when the `exit` event is fired.
PR: #4364
PR-URL: https://github.com/nodejs/node/pull/4364
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Diffstat (limited to 'test/parallel/test-domain-top-level-error-handler-throw.js')
-rw-r--r-- | test/parallel/test-domain-top-level-error-handler-throw.js | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/test/parallel/test-domain-top-level-error-handler-throw.js b/test/parallel/test-domain-top-level-error-handler-throw.js index 2b9e704e43..8f63c94295 100644 --- a/test/parallel/test-domain-top-level-error-handler-throw.js +++ b/test/parallel/test-domain-top-level-error-handler-throw.js @@ -36,10 +36,12 @@ if (process.argv[2] === 'child') { stderrOutput += data.toString(); }); - child.on('exit', function onChildExited(exitCode, signal) { + child.on('close', function onChildClosed() { assert(stderrOutput.indexOf(domainErrHandlerExMessage) !== -1); assert(stderrOutput.indexOf(internalExMessage) === -1); + }); + child.on('exit', function onChildExited(exitCode, signal) { var expectedExitCode = 7; var expectedSignal = null; |