diff options
author | Santiago Gimeno <santiago.gimeno@gmail.com> | 2016-05-29 17:53:40 +0200 |
---|---|---|
committer | Santiago Gimeno <santiago.gimeno@gmail.com> | 2016-07-27 08:25:26 +0200 |
commit | dee0e3a3336473973eda3a8e0e334e96f587572a (patch) | |
tree | 41332997e0022ebb5a29280dbd0bdd13a7d66ecb /test/parallel/test-fs-read-file-sync-hostname.js | |
parent | e22ffefff221caee264ab0b88691478a03ab1862 (diff) | |
download | node-new-dee0e3a3336473973eda3a8e0e334e96f587572a.tar.gz |
test: use common platform helpers everywhere
Use the common.isWindows, common.isFreeBSD and common.isSunOS where
possible.
Add common.isOSX and common.isLinux.
Fix `test-fs-read-file-sync-hostname` as in its current form was not
being run anywhere.
PR-URL: https://github.com/nodejs/node/pull/7845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-fs-read-file-sync-hostname.js')
-rw-r--r-- | test/parallel/test-fs-read-file-sync-hostname.js | 18 |
1 files changed, 11 insertions, 7 deletions
diff --git a/test/parallel/test-fs-read-file-sync-hostname.js b/test/parallel/test-fs-read-file-sync-hostname.js index de10573796..ca300819e7 100644 --- a/test/parallel/test-fs-read-file-sync-hostname.js +++ b/test/parallel/test-fs-read-file-sync-hostname.js @@ -1,10 +1,14 @@ 'use strict'; -require('../common'); -var assert = require('assert'); -var fs = require('fs'); +const common = require('../common'); +const assert = require('assert'); +const fs = require('fs'); -// test reading from hostname -if (process.platform === 'linux2') { - var hostname = fs.readFileSync('/proc/sys/kernel/hostname'); - assert.ok(hostname.length > 0); +if (!common.isLinux) { + common.skip('Test is linux specific.'); + return; } + +// Test to make sure reading a file under the /proc directory works. See: +// https://groups.google.com/forum/#!topic/nodejs-dev/rxZ_RoH1Gn0 +const hostname = fs.readFileSync('/proc/sys/kernel/hostname'); +assert.ok(hostname.length > 0); |