diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-14 16:16:33 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-19 17:55:57 +0200 |
| commit | becc3ec372baeef0a4b89923968d874010966c49 (patch) | |
| tree | d2b29d41da5e3ebde58d2ae04612e28b988c6b28 /test/parallel/test-global.js | |
| parent | f954aba39ee02193beb2dbddc6c0ea0edcca7c74 (diff) | |
| download | node-new-becc3ec372baeef0a4b89923968d874010966c49.tar.gz | |
test: remove common.globalCheck
This flag is partially used in tests where it was not necessary and
it is always possible to replace this flag with
`common.allowGlobals`. This makes sure all globals are truly tested
for.
PR-URL: https://github.com/nodejs/node/pull/20717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-global.js')
| -rw-r--r-- | test/parallel/test-global.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-global.js b/test/parallel/test-global.js index 46db72eece..b139a62874 100644 --- a/test/parallel/test-global.js +++ b/test/parallel/test-global.js @@ -28,7 +28,7 @@ const fixtures = require('../common/fixtures'); const assert = require('assert'); -common.globalCheck = false; +common.allowGlobals('bar', 'foo'); baseFoo = 'foo'; // eslint-disable-line no-undef global.baseBar = 'bar'; |