test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 9 insertions, 9 deletions

diff --git a/test/parallel/test-http-url.parse-auth-with-header-in-request.js b/test/parallel/test-http-url.parse-auth-with-header-in-request.js
index bb5de74ff9..fa930bd5ec 100644
--- a/test/parallel/test-http-url.parse-auth-with-header-in-request.js
+++ b/test/parallel/test-http-url.parse-auth-with-header-in-request.js
@@ -1,16 +1,9 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var assert = require('assert');
 var http = require('http');
 var url = require('url');
 
-var testURL = url.parse('http://asdf:qwer@localhost:' + common.PORT);
-// the test here is if you set a specific authorization header in the
-// request we should not override that with basic auth
-testURL.headers = {
-  Authorization: 'NoAuthForYOU'
-};
-
 function check(request) {
   // the correct authorization header is be passed
   assert.strictEqual(request.headers.authorization, 'NoAuthForYOU');
@@ -24,7 +17,14 @@ var server = http.createServer(function(request, response) {
   server.close();
 });
 
-server.listen(common.PORT, function() {
+server.listen(0, function() {
+  var testURL = url.parse(`http://asdf:qwer@localhost:${this.address().port}`);
+  // the test here is if you set a specific authorization header in the
+  // request we should not override that with basic auth
+  testURL.headers = {
+    Authorization: 'NoAuthForYOU'
+  };
+
   // make the request
   http.request(testURL).end();
 });