diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | node-new-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http.js')
-rw-r--r-- | test/parallel/test-http.js | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/parallel/test-http.js b/test/parallel/test-http.js index 5738fc766d..102567fc2b 100644 --- a/test/parallel/test-http.js +++ b/test/parallel/test-http.js @@ -1,5 +1,5 @@ 'use strict'; -var common = require('../common'); +require('../common'); var assert = require('assert'); var http = require('http'); var url = require('url'); @@ -38,12 +38,12 @@ var server = http.Server(function(req, res) { //assert.equal('127.0.0.1', res.connection.remoteAddress); }); -server.listen(common.PORT); +server.listen(0); server.on('listening', function() { - var agent = new http.Agent({ port: common.PORT, maxSockets: 1 }); + var agent = new http.Agent({ port: this.address().port, maxSockets: 1 }); http.get({ - port: common.PORT, + port: this.address().port, path: '/hello', headers: {'Accept': '*/*', 'Foo': 'bar'}, agent: agent @@ -57,7 +57,7 @@ server.on('listening', function() { setTimeout(function() { var req = http.request({ - port: common.PORT, + port: server.address().port, method: 'POST', path: '/world', agent: agent |