diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-09 02:32:04 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-16 16:53:47 +0100 |
commit | caee112e52b64f4bc1118c4a5fa5ad7b4211efea (patch) | |
tree | 7b60b49da3f863917a23ebc94c00bf2f13cc1348 /test/parallel/test-net-after-close.js | |
parent | 4d3c3f039af08b954fbbba1e9a50979ffc98592b (diff) | |
download | node-new-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.gz |
test: remove assert.doesNotThrow()
There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.
PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-net-after-close.js')
-rw-r--r-- | test/parallel/test-net-after-close.js | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/test/parallel/test-net-after-close.js b/test/parallel/test-net-after-close.js index 1594d36f90..23e265c09a 100644 --- a/test/parallel/test-net-after-close.js +++ b/test/parallel/test-net-after-close.js @@ -34,16 +34,14 @@ server.listen(0, common.mustCall(function() { c.on('close', common.mustCall(function() { console.error('connection closed'); assert.strictEqual(c._handle, null); - assert.doesNotThrow(function() { - c.setNoDelay(); - c.setKeepAlive(); - c.bufferSize; - c.pause(); - c.resume(); - c.address(); - c.remoteAddress; - c.remotePort; - }); + c.setNoDelay(); + c.setKeepAlive(); + c.bufferSize; + c.pause(); + c.resume(); + c.address(); + c.remoteAddress; + c.remotePort; server.close(); })); })); |