test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 7 insertions, 5 deletions

diff --git a/test/parallel/test-net-pingpong.js b/test/parallel/test-net-pingpong.js
index e27ae2f181..33fbafd8f9 100644
--- a/test/parallel/test-net-pingpong.js
+++ b/test/parallel/test-net-pingpong.js
@@ -49,7 +49,7 @@ function pingPongTest(port, host) {
     });
 
     socket.on('close', function() {
-      console.log('server socket.endd');
+      console.log('server socket.end');
       assert.equal(false, socket.writable);
       assert.equal(false, socket.readable);
       socket.server.close();
@@ -58,7 +58,9 @@ function pingPongTest(port, host) {
 
 
   server.listen(port, host, function() {
-    console.log('server listening on ' + port + ' ' + host);
+    if (this.address().port)
+      port = this.address().port;
+    console.log(`server listening on ${port} ${host}`);
 
     var client = net.createConnection(port, host);
 
@@ -108,10 +110,10 @@ function pingPongTest(port, host) {
 /* All are run at once, so run on different ports */
 common.refreshTmpDir();
 pingPongTest(common.PIPE);
-pingPongTest(common.PORT);
-pingPongTest(common.PORT + 1, 'localhost');
+pingPongTest(0);
+pingPongTest(0, 'localhost');
 if (common.hasIPv6)
-  pingPongTest(common.PORT + 2, '::1');
+  pingPongTest(0, '::1');
 
 process.on('exit', function() {
   if (common.hasIPv6)