test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 3 insertions, 3 deletions

diff --git a/test/parallel/test-net-server-max-connections.js b/test/parallel/test-net-server-max-connections.js
index 2b418e1c3c..661c18113b 100644
--- a/test/parallel/test-net-server-max-connections.js
+++ b/test/parallel/test-net-server-max-connections.js
@@ -19,7 +19,7 @@ var server = net.createServer(function(connection) {
   waits.push(function() { connection.end(); });
 });
 
-server.listen(common.PORT, function() {
+server.listen(0, function() {
   makeConnection(0);
 });
 
@@ -29,7 +29,7 @@ console.error('server.maxConnections = %d', server.maxConnections);
 
 
 function makeConnection(index) {
-  var c = net.createConnection(common.PORT);
+  var c = net.createConnection(server.address().port);
   var gotData = false;
 
   c.on('connect', function() {
@@ -78,7 +78,7 @@ function makeConnection(index) {
     // Retry if SmartOS and ECONNREFUSED. See
     // https://github.com/nodejs/node/issues/2663.
     if (common.isSunOS && (e.code === 'ECONNREFUSED')) {
-      c.connect(common.PORT);
+      c.connect(server.address().port);
     }
     console.error('error %d: %s', index, e);
   });