diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-net-server-pause-on-connect.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | node-new-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-net-server-pause-on-connect.js')
-rw-r--r-- | test/parallel/test-net-server-pause-on-connect.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/parallel/test-net-server-pause-on-connect.js b/test/parallel/test-net-server-pause-on-connect.js index f13500b380..798175737b 100644 --- a/test/parallel/test-net-server-pause-on-connect.js +++ b/test/parallel/test-net-server-pause-on-connect.js @@ -37,13 +37,13 @@ const server2ConnHandler = function(socket) { const server2 = net.createServer({pauseOnConnect: false}, server2ConnHandler); -server1.listen(common.PORT, function() { +server1.listen(0, function() { const clientHandler = common.mustCall(function() { - server2.listen(common.PORT + 1, function() { - net.createConnection({port: common.PORT + 1}).write(msg); + server2.listen(0, function() { + net.createConnection({port: this.address().port}).write(msg); }); }); - net.createConnection({port: common.PORT}).write(msg, clientHandler); + net.createConnection({port: this.address().port}).write(msg, clientHandler); }); process.on('exit', function() { |