test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 11 insertions, 11 deletions

diff --git a/test/parallel/test-regress-GH-4948.js b/test/parallel/test-regress-GH-4948.js
index c6953eb78f..0317778787 100644
--- a/test/parallel/test-regress-GH-4948.js
+++ b/test/parallel/test-regress-GH-4948.js
@@ -1,7 +1,7 @@
 'use strict';
 // https://github.com/joyent/node/issues/4948
 
-var common = require('../common');
+require('../common');
 var http = require('http');
 
 var reqCount = 0;
@@ -17,7 +17,7 @@ var server = http.createServer(function(serverReq, serverRes) {
   // normally the use case would be to call an external site
   // does not require connecting locally or to itself to fail
   var r = http.request({hostname: 'localhost',
-                        port: common.PORT}, function(res) {
+                        port: this.address().port}, function(res) {
     // required, just needs to be in the client response somewhere
     serverRes.end();
 
@@ -29,15 +29,15 @@ var server = http.createServer(function(serverReq, serverRes) {
   r.end();
 
   serverRes.write('some data');
-}).listen(common.PORT);
+}).listen(0, function() {
+  // simulate a client request that closes early
+  var net = require('net');
 
-// simulate a client request that closes early
-var net = require('net');
+  var sock = new net.Socket();
+  sock.connect(this.address().port, 'localhost');
 
-var sock = new net.Socket();
-sock.connect(common.PORT, 'localhost');
-
-sock.on('connect', function() {
-  sock.write('GET / HTTP/1.1\r\n\r\n');
-  sock.end();
+  sock.on('connect', function() {
+    sock.write('GET / HTTP/1.1\r\n\r\n');
+    sock.end();
+  });
 });