repl: refactor tests to not rely on timing

Tests relying on synchronous timing have been migrated to use events.

PR-URL: https://github.com/nodejs/node/pull/17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 files changed, 25 insertions, 25 deletions

diff --git a/test/parallel/test-repl-eval.js b/test/parallel/test-repl-eval.js
index d775423fb7..d7290a1583 100644
--- a/test/parallel/test-repl-eval.js
+++ b/test/parallel/test-repl-eval.js
@@ -3,31 +3,31 @@ const common = require('../common');
 const assert = require('assert');
 const repl = require('repl');
 
-{
-  let evalCalledWithExpectedArgs = false;
+const exitTests = [];
+process.on('exit', () => {
+  for (const test of exitTests) test();
+});
+const options = {
+  eval: common.mustCall((cmd, context) => {
+    // Assertions here will not cause the test to exit with an error code
+    // so set a boolean that is checked later instead.
+    exitTests.push(common.mustCall(() => {
+      assert.strictEqual(cmd, 'function f() {}\n');
+      assert.strictEqual(context.foo, 'bar');
+    }));
+  })
+};
 
-  const options = {
-    eval: common.mustCall((cmd, context) => {
-      // Assertions here will not cause the test to exit with an error code
-      // so set a boolean that is checked later instead.
-      evalCalledWithExpectedArgs = (cmd === 'function f() {}\n' &&
-                                    context.foo === 'bar');
-    })
-  };
+const r = repl.start(options);
+r.context = { foo: 'bar' };
 
-  const r = repl.start(options);
-  r.context = { foo: 'bar' };
-
-  try {
-    // Default preprocessor transforms
-    //  function f() {}  to
-    //  var f = function f() {}
-    // Test to ensure that original input is preserved.
-    // Reference: https://github.com/nodejs/node/issues/9743
-    r.write('function f() {}\n');
-  } finally {
-    r.write('.exit\n');
-  }
-
-  assert(evalCalledWithExpectedArgs);
+try {
+  // Default preprocessor transforms
+  //  function f() {}  to
+  //  var f = function f() {}
+  // Test to ensure that original input is preserved.
+  // Reference: https://github.com/nodejs/node/issues/9743
+  r.write('function f() {}\n');
+} finally {
+  r.write('.exit\n');
 }