test: refactor common.expectsError

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 files changed, 3 insertions, 2 deletions

diff --git a/test/parallel/test-zlib-not-string-or-buffer.js b/test/parallel/test-zlib-not-string-or-buffer.js
index 6a3b2b772f..b7b9a465cb 100644
--- a/test/parallel/test-zlib-not-string-or-buffer.js
+++ b/test/parallel/test-zlib-not-string-or-buffer.js
@@ -4,6 +4,7 @@
 // or buffer.
 
 const common = require('../common');
+const assert = require('assert');
 const zlib = require('zlib');
 
 [
@@ -16,11 +17,11 @@ const zlib = require('zlib');
   [1, 2, 3],
   { foo: 'bar' }
 ].forEach((input) => {
-  common.expectsError(
+  assert.throws(
     () => zlib.deflateSync(input),
     {
       code: 'ERR_INVALID_ARG_TYPE',
-      type: TypeError,
+      name: 'TypeError',
       message: 'The "buffer" argument must be of type string or an instance ' +
                'of Buffer, TypedArray, DataView, or ArrayBuffer.' +
                common.invalidArgTypeHelper(input)