summaryrefslogtreecommitdiff
path: root/test/parallel
diff options
context:
space:
mode:
authorBenjamin Gruenbaum <benji@peer5.com>2018-07-26 17:05:48 +0300
committerJon Moss <me@jonathanmoss.me>2018-08-02 22:33:51 -0400
commitd68f946fe4ebaba02d68f5b118d53ec397ac705e (patch)
tree39065554782b8653c06661d7f1eb61b297b107ca /test/parallel
parent8d15f69abd6502cedbc64597085bddfd9774b7a5 (diff)
downloadnode-new-d68f946fe4ebaba02d68f5b118d53ec397ac705e.tar.gz
test: remove unused config
process.maxTickDepth was removed in v0.12 a whole while ago and was mostly removed from our code base. There are still some places it was left in old benchmarks and tests. This PR removes setting the value in those tests and benchmarks. PR-URL: https://github.com/nodejs/node/pull/21985 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Diffstat (limited to 'test/parallel')
-rw-r--r--test/parallel/test-next-tick-intentional-starvation.js8
-rw-r--r--test/parallel/test-stream2-read-sync-stack.js8
2 files changed, 6 insertions, 10 deletions
diff --git a/test/parallel/test-next-tick-intentional-starvation.js b/test/parallel/test-next-tick-intentional-starvation.js
index fdcdd6a7a6..26d07e02ea 100644
--- a/test/parallel/test-next-tick-intentional-starvation.js
+++ b/test/parallel/test-next-tick-intentional-starvation.js
@@ -23,12 +23,8 @@
require('../common');
const assert = require('assert');
-// this is the inverse of test-next-tick-starvation.
-// it verifies that process.nextTick will *always* come before other
-// events, up to the limit of the process.maxTickDepth value.
-
-// WARNING: unsafe!
-process.maxTickDepth = Infinity;
+// this is the inverse of test-next-tick-starvation. it verifies
+// that process.nextTick will *always* come before other events
let ran = false;
let starved = false;
diff --git a/test/parallel/test-stream2-read-sync-stack.js b/test/parallel/test-stream2-read-sync-stack.js
index 3fa84547fe..e6a5ea7e52 100644
--- a/test/parallel/test-stream2-read-sync-stack.js
+++ b/test/parallel/test-stream2-read-sync-stack.js
@@ -22,13 +22,13 @@
'use strict';
const common = require('../common');
const Readable = require('stream').Readable;
+
+// This tests synchronous read callbacks and verifies that even if they nest
+// heavily the process handles it without an error
+
const r = new Readable();
const N = 256 * 1024;
-// Go ahead and allow the pathological case for this test.
-// Yes, it's an infinite loop, that's the point.
-process.maxTickDepth = N + 2;
-
let reads = 0;
r._read = function(n) {
const chunk = reads++ === N ? null : Buffer.allocUnsafe(1);