diff options
| author | Matheus Marchini <mat@mmarchini.me> | 2019-04-16 16:27:28 -0700 |
|---|---|---|
| committer | Matheus Marchini <mat@mmarchini.me> | 2019-04-18 16:57:23 -0700 |
| commit | 8712edf53a5f71f183a6a49b364d2bcb439d00ff (patch) | |
| tree | 359dc5faa3f6fab59c08a70f2e02a4c129bf9245 /test/v8-updates | |
| parent | 7f29117de3329adf10e0d8911eaa7460968fa680 (diff) | |
| download | node-new-8712edf53a5f71f183a6a49b364d2bcb439d00ff.tar.gz | |
test: fix postmortem metadata test
Recent changes to spawnSync (https://github.com/nodejs/node/pull/23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.
PR-URL: https://github.com/nodejs/node/pull/27265
Refs: https://github.com/v8/v8/compare/7.4.288.18...7.4.288.21
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/v8-updates')
| -rw-r--r-- | test/v8-updates/test-postmortem-metadata.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index cce4a4d227..c6704ef1e3 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -21,7 +21,7 @@ if (common.isAIX) if (common.isOpenBSD) common.skip('no v8 debug symbols on OpenBSD'); -const nm = spawnSync('nm', args); +const nm = spawnSync('nm', args, { maxBuffer: Infinity }); if (nm.error && nm.error.errno === 'ENOENT') common.skip('nm not found on system'); |