diff options
author | Anatoli Papirovski <apapirovski@mac.com> | 2017-10-16 18:37:14 -0400 |
---|---|---|
committer | Anatoli Papirovski <apapirovski@mac.com> | 2017-10-19 13:54:14 -0400 |
commit | 3c0ebf5aca935ebacf4f5b862c2ad4fb67614bcb (patch) | |
tree | 84859056d1bd5a434d64e7baa4f0f1aca0f96bad /tools | |
parent | bf1bacef6bc49fa39a272ca63b7635de3e5e7f08 (diff) | |
download | node-new-3c0ebf5aca935ebacf4f5b862c2ad4fb67614bcb.tar.gz |
tools: enable additional eslint rules
Enable additional rules that node either already adheres to
or it makes sense to do so going forward: for-direction,
accessor-pairs, no-lonely-if and symbol-description.
Fix all instances of no-lonely-if in lib & test and disable
accessor-pairs in test-util-inspect.
PR-URL: https://github.com/nodejs/node/pull/16243
Refs: https://eslint.org/docs/rules/for-direction
Refs: https://eslint.org/docs/rules/accessor-pairs
Refs: https://eslint.org/docs/rules/no-lonely-if
Refs: https://eslint.org/docs/rules/symbol-description
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/eslint-rules/rules-utils.js | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tools/eslint-rules/rules-utils.js b/tools/eslint-rules/rules-utils.js index e3e5e6e5ef..f2f5428ed1 100644 --- a/tools/eslint-rules/rules-utils.js +++ b/tools/eslint-rules/rules-utils.js @@ -43,10 +43,8 @@ module.exports.inSkipBlock = function(node) { } return false; }); - } else { - if (hasSkip(consequent.expression)) { - hasSkipBlock = true; - } + } else if (hasSkip(consequent.expression)) { + hasSkipBlock = true; } } return hasSkipBlock; |