diff options
Diffstat (limited to 'deps/v8/src/codegen/x64/constants-x64.h')
| -rw-r--r-- | deps/v8/src/codegen/x64/constants-x64.h | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/deps/v8/src/codegen/x64/constants-x64.h b/deps/v8/src/codegen/x64/constants-x64.h index 775abecd9f..0ff9fcfa66 100644 --- a/deps/v8/src/codegen/x64/constants-x64.h +++ b/deps/v8/src/codegen/x64/constants-x64.h @@ -9,13 +9,18 @@ namespace v8 { namespace internal { -// Actual value of root register is offset from the root array's start + +// The actual value of the kRootRegister is offset from the IsolateData's start // to take advantage of negative displacement values. -// TODO(sigurds): Choose best value. -// TODO(ishell): Choose best value for ptr-compr. -constexpr int kRootRegisterBias = kSystemPointerSize == kTaggedSize ? 128 : 0; +// On x64, the smallest operand encoding allows int8 offsets, thus we select the +// bias s.t. the first 32 8-byte slots of IsolateData are can be encoded this +// way. +constexpr int kRootRegisterBias = 128; +// The maximum size of the code range s.t. pc-relative calls are possible +// between all Code objects in the range. constexpr size_t kMaxPCRelativeCodeRangeInMB = 2048; + } // namespace internal } // namespace v8 |