summaryrefslogtreecommitdiff
path: root/deps/v8/src/debug/debug-coverage.cc
diff options
context:
space:
mode:
Diffstat (limited to 'deps/v8/src/debug/debug-coverage.cc')
-rw-r--r--deps/v8/src/debug/debug-coverage.cc8
1 files changed, 6 insertions, 2 deletions
diff --git a/deps/v8/src/debug/debug-coverage.cc b/deps/v8/src/debug/debug-coverage.cc
index c434cede65..fa598f4650 100644
--- a/deps/v8/src/debug/debug-coverage.cc
+++ b/deps/v8/src/debug/debug-coverage.cc
@@ -560,7 +560,7 @@ void CollectAndMaybeResetCounts(Isolate* isolate,
// feedback allocation we may miss counting functions if the feedback
// vector wasn't allocated yet and the function's interrupt budget wasn't
// updated (i.e. it didn't execute return / jump).
- for (JavaScriptFrameIterator it(isolate); !it.done(); it.Advance()) {
+ for (JavaScriptStackFrameIterator it(isolate); !it.done(); it.Advance()) {
SharedFunctionInfo shared = it.frame()->function().shared();
if (counter_map->Get(shared) != 0) continue;
counter_map->Add(shared, 1);
@@ -621,6 +621,10 @@ std::unique_ptr<Coverage> Coverage::CollectBestEffort(Isolate* isolate) {
std::unique_ptr<Coverage> Coverage::Collect(
Isolate* isolate, v8::debug::CoverageMode collectionMode) {
+ // Unsupported if jitless mode is enabled at build-time since related
+ // optimizations deactivate invocation count updates.
+ CHECK(!V8_JITLESS_BOOL);
+
// Collect call counts for all functions.
SharedToCounterMap counter_map;
CollectAndMaybeResetCounts(isolate, &counter_map, collectionMode);
@@ -709,7 +713,7 @@ std::unique_ptr<Coverage> Coverage::Collect(
}
}
- Handle<String> name = SharedFunctionInfo::DebugName(info);
+ Handle<String> name = SharedFunctionInfo::DebugName(isolate, info);
CoverageFunction function(start, end, count, name);
if (IsBlockMode(collectionMode) && info->HasCoverageInfo()) {