diff options
Diffstat (limited to 'deps/v8/test/cctest/test-trace-event.cc')
-rw-r--r-- | deps/v8/test/cctest/test-trace-event.cc | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/deps/v8/test/cctest/test-trace-event.cc b/deps/v8/test/cctest/test-trace-event.cc index 10b837aaed..f73641d9cf 100644 --- a/deps/v8/test/cctest/test-trace-event.cc +++ b/deps/v8/test/cctest/test-trace-event.cc @@ -39,7 +39,7 @@ typedef std::vector<MockTraceObject*> MockTraceObjectList; class MockTracingController : public v8::TracingController { public: MockTracingController() = default; - ~MockTracingController() { + ~MockTracingController() override { for (size_t i = 0; i < trace_object_list_.size(); ++i) { delete trace_object_list_[i]; } @@ -98,7 +98,7 @@ class MockTracingPlatform : public TestPlatform { // Now that it's completely constructed, make this the current platform. i::V8::SetPlatformForTesting(this); } - virtual ~MockTracingPlatform() {} + ~MockTracingPlatform() override = default; v8::TracingController* GetTracingController() override { return &tracing_controller_; @@ -289,7 +289,6 @@ TEST(BuiltinsIsTraceCategoryEnabled) { v8::Isolate* isolate = CcTest::isolate(); v8::HandleScope handle_scope(isolate); - v8::Local<v8::Context> context = isolate->GetCurrentContext(); LocalContext env; v8::Local<v8::Object> binding = env->GetExtrasBindingObject(); @@ -308,7 +307,7 @@ TEST(BuiltinsIsTraceCategoryEnabled) { .ToLocalChecked() .As<v8::Boolean>(); - CHECK(result->BooleanValue(context).ToChecked()); + CHECK(result->BooleanValue(isolate)); } { @@ -318,7 +317,7 @@ TEST(BuiltinsIsTraceCategoryEnabled) { .ToLocalChecked() .As<v8::Boolean>(); - CHECK(!result->BooleanValue(context).ToChecked()); + CHECK(!result->BooleanValue(isolate)); } { @@ -328,7 +327,7 @@ TEST(BuiltinsIsTraceCategoryEnabled) { .ToLocalChecked() .As<v8::Boolean>(); - CHECK(result->BooleanValue(context).ToChecked()); + CHECK(result->BooleanValue(isolate)); } } @@ -362,7 +361,7 @@ TEST(BuiltinsTrace) { .ToLocalChecked() .As<v8::Boolean>(); - CHECK(!result->BooleanValue(context).ToChecked()); + CHECK(!result->BooleanValue(isolate)); CHECK_EQ(0, GET_TRACE_OBJECTS_LIST->size()); } @@ -381,7 +380,7 @@ TEST(BuiltinsTrace) { .ToLocalChecked() .As<v8::Boolean>(); - CHECK(result->BooleanValue(context).ToChecked()); + CHECK(result->BooleanValue(isolate)); CHECK_EQ(1, GET_TRACE_OBJECTS_LIST->size()); CHECK_EQ(123, GET_TRACE_OBJECT(0)->id); @@ -405,7 +404,7 @@ TEST(BuiltinsTrace) { .ToLocalChecked() .As<v8::Boolean>(); - CHECK(result->BooleanValue(context).ToChecked()); + CHECK(result->BooleanValue(isolate)); CHECK_EQ(2, GET_TRACE_OBJECTS_LIST->size()); CHECK_EQ(123, GET_TRACE_OBJECT(1)->id); |