summaryrefslogtreecommitdiff
path: root/deps/v8
Commit message (Collapse)AuthorAgeFilesLines
* deps: V8: cherry-pick 5f025d1ca2caMichaël Zasso2023-05-101-22/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [wasm] Fix deadlock in async wrapper compilation If compilation is cancelled while wrapper compilation is running, the tasks spawned for the {AsyncCompileJSToWasmWrapperJob} will return immediately, but {GetMaxConcurrency} will still return a positive value. Hence {Join()} will spawn another task, resulting in a livelock. We could fix this by checking for cancellation in {GetMaxConcurrency}, but that requires taking the compilation state lock. So this CL fixes the issue by dropping the number of outstanding compilation units by to (basically) zero. We can't unconditionally drop to zero because another thread might concurrently execute a wrapper compilation and still call {CompleteUnit} afterwards. Hence only drop outstanding units by the amount of not-yet-started units. R=jkummerow@chromium.org Bug: v8:13858 Change-Id: I5398ef370da2e7f212ca772fd1f87f659929dd6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4437531 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#87143} Refs: https://github.com/v8/v8/commit/5f025d1ca2ca2fe2f6cee5b6d841907a36fd32b7 PR-URL: https://github.com/nodejs/node/pull/47610 Refs: https://github.com/nodejs/node/issues/47297 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: cherry-pick a8a11a87cb72Michaël Zasso2023-05-101-136/+127
| | | | | | | | | | | | | | | | | | | | | | | Original commit message: [wasm] Simplify CompileJSToWasmWrapperJob This CL merges some of AsyncCompileJSToWasmWrapperJob and CompileJSToWasmWrapperJob into a common base class. Both jobs now loop on a vector with an atomic index. Bug: chromium:1423615 Change-Id: I7bb9cb2a57d8b659766c01e20e38d1b859d3a987 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4347597 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#86675} Refs: https://github.com/v8/v8/commit/a8a11a87cb72c698cd35a5df3a23f0d08340b6d1 PR-URL: https://github.com/nodejs/node/pull/47610 Refs: https://github.com/nodejs/node/issues/47297 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: cherry-pick 1b471b796022Lu Yahan2023-05-073-10/+16
| | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [riscv] Using s8 as backtrack_stackpointer reg and optimize BranchShortHelper 1. Fix incorrect backtrack_stackpointer reg. 2. Optimize BranchShortHelper when comparing zero immediate. 3. This is a workaround CL fix v8:13836 Bug: v8:13836 Change-Id: I4cfc9df92fcd38ecd448a41ee87d1e251efd4ad9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394942 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#86889} Refs: https://github.com/v8/v8/commit/1b471b79602235c13202b5b52eeb34603cee7a91 PR-URL: https://github.com/nodejs/node/pull/47399 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: disable V8 concurrent sparkplug compilationMichaël Zasso2023-05-011-1/+1
| | | | | | | | | | | | | | | It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: https://github.com/nodejs/node/issues/47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: https://github.com/nodejs/node/pull/47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: cherry-pick c5ab3e4f0c5aRichard Lau2023-04-281-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | Original commit message: libstdc++: fix incomplete type in v8::internal::is_subtype<T, U> Using std::convertible with incomplete types is UB. However, till GCC 12 it was accepted and std::convertible returned false. This fails now for e.g. v8::internal::WasmArray. Use std::disjunction and std::conjunction instead which are short- circuiting, because std::is_base_of<T, T> is already true. Bug: chromium:957519 Change-Id: Ia26643dbdf0fb00d5586c71ae6b18e8d0f3cf96e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394663 Commit-Queue: Stephan Hartmann <stha09@googlemail.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#86904} Refs: https://github.com/v8/v8/commit/c5ab3e4f0c5a3ce880941184ef8447c27cd19a93 PR-URL: https://github.com/nodejs/node/pull/47736 Fixes: https://github.com/nodejs/node/issues/47623 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* deps: patch V8 to 11.3.244.8Michaël Zasso2023-04-176-2/+27
| | | | | | | Refs: https://github.com/v8/v8/compare/11.3.244.4...11.3.244.8 PR-URL: https://github.com/nodejs/node/pull/47536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* deps: V8: cherry-pick 8e10685ff918Jiawen Geng2023-04-111-2/+2
| | | | | | | | | | | | | | | | | Original commit message: [build]: fix wrong name Change-Id: I504e836da1e36d7b9e504dbdbff8803363f08ccd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4392064 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#86919} Refs: https://github.com/v8/v8/commit/8e10685ff9187ab1b4041a1b320dc6012c09c460 PR-URL: https://github.com/nodejs/node/pull/47440 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: patch V8 to support compilation on win-arm64Michaël Zasso2023-03-313-13/+20
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: silence irrelevant V8 warningMichaël Zasso2023-03-311-1/+1
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: always define V8_EXPORT_PRIVATE as no-opMichaël Zasso2023-03-311-3/+3
| | | | | | | | | | dllexport introduces issues when compiling with MSVC. PR-URL: https://github.com/nodejs/node/pull/47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: update V8 to 11.3.244.4Michaël Zasso2023-03-312560-108286/+174760
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 3e4952cb2a59Richard Lau2023-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | Original commit message: [test] fix uninitialized error In op1a.Equals(&op3) call, that->parameter() is undefined. which triggers uninitialized error from gcc. Change-Id: I87f1fcba3e57adbb5a1e745a3d787c62a87fd1d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4307714 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#86267} Refs: https://github.com/v8/v8/commit/3e4952cb2a5969e42e782a66b948dc0ee88c812e PR-URL: https://github.com/nodejs/node/pull/47236 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* deps: V8: cherry-pick 215ccd593edbJoyee Cheung2023-03-241-1/+1
| | | | | | | | | | | | | | | | | | | | | Original commit message: Use FlagValue::value() in SLOW_DCHECK Previously SLOW_DCHECK used the non-constexpr bool() operator of FlagValue, which cannot be used in constexpr. Switch to FlagValue::value() instead for make it compile in constexpr. Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495 Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#86611} Refs: https://github.com/v8/v8/commit/215ccd593edbf18170fa1aae109b6b1cccf0ccbf PR-URL: https://github.com/nodejs/node/pull/47212 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 975ff4dbfd1bDebadree Chatterjee2023-03-243-2/+113
| | | | | | | | | | | | | | | | | | | | | | | Original commit message: fix GetPropertyNames for proxys with ownKeys trap Added checks to FilterProxyKeys function for when skip_indices is enabled. Bug: v8:13728 Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#86548} Refs: https://github.com/v8/v8/commit/975ff4dbfd1be3a7395e26d412774bc955b47341 PR-URL: https://github.com/nodejs/node/pull/47209 Fixes: https://github.com/nodejs/node/issues/41714 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
* deps: V8: cherry-pick 90be99fab31cMichaël Zasso2023-02-204-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [intl] Revert date formatting behavior change from ICU 72 Replace U+202F with U+0020 after formatting date. This lets websites continue to work without any changes. This matches Firefox behavior, according to https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17. Bug: chromium:1414292, chromium:1401829, chromium:1392814 Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#85757} Refs: https://github.com/v8/v8/commit/90be99fab31c8299568e4114be1f0abd3741d615 PR-URL: https://github.com/nodejs/node/pull/46646 Refs: https://github.com/nodejs/node/issues/46123 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* deps: V8: cherry-pick e39af94dd18eLu Yahan2023-01-193-10/+13
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [riscv64] Fix failed: vector[] index out of GenPCRelativeJumpAndLink doesn't use BlockTrampolinePoolScope. It inserts a BlockTrampolinePool which causes this error. And also alter debug info format. Change-Id: I160f13f4261fdcf1f7978bfce9b5169d363e6a10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4032016 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#84316} Refs: https://github.com/v8/v8/commit/e39af94dd18e6079cfd91d4d1751c3c21c723230 PR-URL: https://github.com/nodejs/node/pull/46142 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: cherry-pick 30861a39323dAaron Friel2023-01-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [debug] Re-enable internal [[Scopes]] property We received feedback that the [[Scopes]] property has some legitimate use-cases not covered by the Scopes View during pause. We re-enable the feature for now and will remove the flag in a follow-up. R=bmeurer@chromium.org Bug: chromium:1365858 Change-Id: Ibf279ae6c4f5ae492d03e9b4ee7316f6500508d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4099385 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#84800} Refs: https://github.com/v8/v8/commit/30861a39323d2d4263b2b9f5d9740134d4104cd3 PR-URL: https://github.com/nodejs/node/pull/45851 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: patch V8 to 10.9.194.9Michaël Zasso2022-12-316-7/+41
| | | | | | Refs: https://github.com/v8/v8/compare/10.9.194.6...10.9.194.9 PR-URL: https://github.com/nodejs/node/pull/45995 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* deps: V8: backport 8ca9f77d0f7cAnna Henningsen2022-12-2110-62/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a crash when loading snapshots that contain empty ArrayBuffer instances: ```js const X = []; X.push(new ArrayBuffer()); v8.startupSnapshot.setDeserializeMainFunction(() => { for (let i = 0; i < 1000000; i++) { // trigger GC X.push(new ArrayBuffer()); } }) ``` Original commit message: [sandbox] Sandboxify JSArrayBuffer::extension external pointer Bug: chromium:1335043 Change-Id: Id8e6883fc652b144f6380ff09b1c18e777e041c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3706626 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#84544} Refs: https://github.com/v8/v8/commit/8ca9f77d0f7c2d5ec5ef8255b9689f5ac1c547a3 PR-URL: https://github.com/nodejs/node/pull/45871 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: cherry-pick bc831f8ba33bYagiz Nizipli2022-12-107-1/+199
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [fastcall] Implement support for onebyte string arguments This CL adds one byte string specialization support for fast API call arguments. It introduces a kOneByteString variant to CTypeInfo. We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark. Rendered results: https://divy-v8-patches.deno.dev/ Bug: chromium:1052746 Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#84552} Refs: https://github.com/v8/v8/commit/bc831f8ba33b79e2eb670faf1f84c4e39aeb0f9f PR-URL: https://github.com/nodejs/node/pull/45788 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
* deps: patch V8 to 10.9.194.6Michaël Zasso2022-12-085-73/+49
| | | | | | | | Refs: https://github.com/v8/v8/compare/10.9.194.4...10.9.194.6 PR-URL: https://github.com/nodejs/node/pull/45748 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: V8: cherry-pick f1c888e7093eMichaël Zasso2022-11-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [base] Fix SmartOS build That platform doesn't have `malloc_usable_size`. Refs: https://github.com/nodejs/node-v8/issues/239 Change-Id: I011dd8449d02b27219a32cba00132cd068069f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/main@{#84256} Refs: https://github.com/v8/v8/commit/f1c888e7093eca98a5064a3d0c0c678959bee11d PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> # Conflicts: # common.gypi PR-URL: https://github.com/nodejs/node/pull/45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: fix V8 build on Windows with MSVCMichaël Zasso2022-11-271-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: silence irrelevant V8 warningMichaël Zasso2022-11-271-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: fix v8-cppgc.h for MSVCJiawen Geng2022-11-271-0/+3
| | | | | | | | | | | | | | Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: https://github.com/nodejs/node/issues/42375 PR-URL: https://github.com/nodejs/node/pull/42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> PR-URL: https://github.com/nodejs/node/pull/45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: fix V8 build issue with inline methodsJiawen Geng2022-11-273-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> deps: patch for v8 on windows PR-URL: https://github.com/nodejs/node/pull/40010 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> deps: patch v8 for vs2019 in std17 PR-URL: https://github.com/nodejs/node/pull/40060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> deps: workaround debug link error on Windows PR-URL: https://github.com/nodejs/node/pull/38807 Refs: https://github.com/nodejs/node/pull/38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> PR-URL: https://github.com/nodejs/node/pull/45579
* deps: update V8 to 10.9.194.4Yagiz Nizipli2022-11-27876-19111/+35936
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: cherry-pick 2ada52cffbffMichaël Zasso2022-11-243-2/+51
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [intl] Enhance Date parser to take Unicode SPACE This is needed to prepare for the landing of ICU72. Allow U+202F in the Date String, which the toLocaleString("en-US") will generate w/ ICU72. Bug: v8:13494 Change-Id: I41b83c4094ce3d0737a72dcd6310b52c68fdcdca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027341 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#84308} Refs: https://github.com/v8/v8/commit/2ada52cffbff11074abfaac18938bf02d85454f5 Fixes: https://github.com/nodejs/node/issues/45171 PR-URL: https://github.com/nodejs/node/pull/45573 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* build,deps,src: fix Intel VTune profiling supportShi Lei2022-11-2237-0/+16529
| | | | | PR-URL: https://github.com/nodejs/node/pull/45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* deps: V8: cherry-pick f1c888e7093eMichaël Zasso2022-11-191-2/+2
| | | | | | | | | | | | | | | | | | | | Original commit message: [base] Fix SmartOS build That platform doesn't have `malloc_usable_size`. Refs: https://github.com/nodejs/node-v8/issues/239 Change-Id: I011dd8449d02b27219a32cba00132cd068069f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/main@{#84256} Refs: https://github.com/v8/v8/commit/f1c888e7093eca98a5064a3d0c0c678959bee11d PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: V8: cherry-pick 92a7385171bbMichaël Zasso2022-11-192-3/+25
| | | | | | | | | | | | | | | | | | | | Original commit message: [heap] Fix 32bit msvc builds Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus forcing 8 bytes alignment for MemoryChunk. Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#83845} Refs: https://github.com/v8/v8/commit/92a7385171bb55840351533e0761eb4a1c5e7dd4 PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: fix V8 build on Windows with MSVCMichaël Zasso2022-11-191-1/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: silence irrelevant V8 warningMichaël Zasso2022-11-191-1/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: V8: fix v8-cppgc.h for MSVCJiawen Geng2022-11-191-0/+3
| | | | | | | | | | | | | Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: https://github.com/nodejs/node/issues/42375 PR-URL: https://github.com/nodejs/node/pull/42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: fix V8 build issue with inline methodsJiawen Geng2022-11-193-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> deps: patch for v8 on windows PR-URL: https://github.com/nodejs/node/pull/40010 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> deps: patch v8 for vs2019 in std17 PR-URL: https://github.com/nodejs/node/pull/40060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> deps: workaround debug link error on Windows PR-URL: https://github.com/nodejs/node/pull/38807 Refs: https://github.com/nodejs/node/pull/38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: update V8 to 10.8.168.20Michaël Zasso2022-11-191255-25116/+51354
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: V8: cherry-pick 9df5ef70ff18Yagiz Nizipli2022-11-185-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: Add an `v8::ArrayBuffer::WasDetached` method to the C++ API V8's C++ API does not give a way to tell whether an ArrayBuffer has been detached from the `v8::ArrayBuffer` class. In fact, as far as can be told from the C++ API without running JS code, detached ArrayBuffers behave the same as zero-sized ArrayBuffers and there is no way to observe the difference. However, this difference can be observed in JS because constructing a TypedArray from a detached ArrayBuffer will throw. This change adds a `WasDetached` method to the `v8::ArrayBuffer` class to give embedders access to this information without having to run JS code. Bug: v8:13159 Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#83963} Refs: https://github.com/v8/v8/commit/9df5ef70ff18977b157028fc55ced5af4bcee535 PR-URL: https://github.com/nodejs/node/pull/45474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: patch V8 to 10.7.193.22Michaël Zasso2022-11-163-53/+49
| | | | | | | Refs: https://github.com/v8/v8/compare/10.7.193.20...10.7.193.22 PR-URL: https://github.com/nodejs/node/pull/45460 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: V8: cherry-pick 031b98b25cbaMichaël Zasso2022-11-114-0/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [runtime] Clear array join stack when throwing uncatchable ... exception. Array#join depends array_join_stack to avoid infinite loop and ensures symmetric pushes/pops through catch blocks to correctly maintain the elements in the join stack. However, the stack does not pop the elements and leaves in an invalid state when throwing the uncatchable termination exception. And the invalid join stack state will affect subsequent Array#join calls. Because all the terminate exception will be handled by Isolate::UnwindAndFindHandler, we could clear the array join stack when unwinding the terminate exception. Bug: v8:13259 Change-Id: I23823e823c5fe0b089528c5cf654864cea78ebeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3878451 Reviewed-by: Jakob Linke <jgruber@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#83465} Refs: https://github.com/v8/v8/commit/031b98b25cbaaa4c62d8544f5f667d33ea4076c4 Closes: https://github.com/nodejs/node/issues/44417 PR-URL: https://github.com/nodejs/node/pull/45375 Fixes: https://github.com/nodejs/node/issues/44417 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
* deps: V8: cherry-pick 56816d76c121Shi Pujin2022-11-081-0/+2
| | | | | | | | | | | | | | | | Original commit message: [loong64] Supplement a LoongArch support in include/v8config.h Change-Id: I658c1b781163bcd3ca39bfceb74aef9d255247b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3894795 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Liu Yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#83374} PR-URL: https://github.com/nodejs/node/pull/45353 Refs: https://github.com/v8/v8/commit/56816d76c121c8dd5b406dc6019350eee05f4abd Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* deps: patch V8 to 10.7.193.20Michaël Zasso2022-11-064-6/+19
| | | | | | Refs: https://github.com/v8/v8/compare/10.7.193.16...10.7.193.20 PR-URL: https://github.com/nodejs/node/pull/45228 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* Revert "deps: make V8 compilable with older glibc"Michaël Zasso2022-10-271-0/+19
| | | | | | | | | | | | This reverts commit 84d455e08e4129f7d1b3c68d62cbb129458619ec. PR-URL: https://github.com/nodejs/node/pull/45162 Refs: https://github.com/nodejs/node/issues/45118 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Revert "deps: V8: forward declaration of `Rtl*FunctionTable`"Michaël Zasso2022-10-251-30/+0
| | | | | | | | | | This reverts commit 01bc8e6fd81314e76c7fb0d09e5310f609e48bee. PR-URL: https://github.com/nodejs/node/pull/45119 Refs: https://github.com/nodejs/node/issues/45118 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* deps: patch V8 to 10.7.193.16Michaël Zasso2022-10-187-21/+148
| | | | | | | | | | Refs: https://github.com/v8/v8/compare/10.7.193.13...10.7.193.16 PR-URL: https://github.com/nodejs/node/pull/45023 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* deps: V8: cherry-pick c2792e58035fJiawen Geng2022-10-143-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [base] Fix build with gcc-13 See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes. Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981 Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140 Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#83587} Refs: https://github.com/v8/v8/commit/c2792e58035fcbaa16d0cb70998852fbeb5df4cc PR-URL: https://github.com/nodejs/node/pull/44961 Fixes: https://github.com/nodejs/node/issues/43642 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* deps: V8: cherry-pick c3dffe6e2bdaMichaël Zasso2022-10-134-31/+94
| | | | | | | | | | | | | | | | | | | | | | Original commit message: [api] Expose parsed module source map urls Source map urls can be parsed from the magic comments. Expose them with public apis on the UnboundModuleScript, similar to the UnboundScript. Change-Id: Ia5dfdc8ff25f825c9fa7d241d0d79ba20028586b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3917379 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Chengzhong Wu (legendecas) <legendecas@gmail.com> Cr-Commit-Position: refs/heads/main@{#83527} Refs: https://github.com/v8/v8/commit/c3dffe6e2bdab79bb5bfb94be9fcc6a16adf6cf5 PR-URL: https://github.com/nodejs/node/pull/44958 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick e7f0f26f5ef3Michaël Zasso2022-10-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Original commit message: Don't run sampling-heap-profiler-flags with stress-incremental-marking This test observes GC behavior and needs the garbage collector to work in a somewhat predictable way. Bug: v8:13286 Change-Id: I24e6a4f33a644b5f1845cd34558da03fc196f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3898721 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#83218} Refs: https://github.com/v8/v8/commit/e7f0f26f5ef34db70e944218e72febb4fbe7eaa8 PR-URL: https://github.com/nodejs/node/pull/44958 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 3d59a3c2c164Michaël Zasso2022-10-139-8/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: Add option to report discarded allocations in sampling heap profiler A couple of customers have asked about using devtools to get information about temporary allocations, with the goal of reducing GC time and/or peak memory usage. Currently, the sampling heap profiler reports only objects which are still alive at the end of the profiling session. In this change, I propose adding configuration options when starting the sampling heap profiler so that it can optionally include information about objects which were discarded by the GC before the end of the profiling session. A user could run the sampling heap profiler in several different modes depending on their goals: 1. To find memory leaks or determine which functions contribute most to steady-state memory consumption, the current default mode is best. 2. To find functions which cause large temporary memory spikes or large GC pauses, the user can request data about both live objects and those collected by major GC. 3. To tune for minimal GC activity in latency-sensitive applications like real-time audio processing, the user can request data about every allocation, including objects collected by major or minor GC. 4. I'm not sure why anybody would want data about objects collected by minor GC and not objects collected by major GC, but it's also a valid flags combination. Change-Id: If55d5965a1de04fed3ae640a02ca369723f64fdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3868522 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#83202} Refs: https://github.com/v8/v8/commit/3d59a3c2c16405eea59263300c5591c3283a2a0e PR-URL: https://github.com/nodejs/node/pull/44958 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 8b8703953616Michaël Zasso2022-10-131-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [API] Remove second OnCriticalMemoryPressure Remove the deprecated OnCriticalMemoryPressure method with receives an informative parameter. R=mlippautz@chromium.org Bug: chromium:634547 Change-Id: I932c3b5030291294dd340362f0b20d374e3067c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780533 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#83254} Refs: https://github.com/v8/v8/commit/8b870395361633a134a257c604470378d06335ed PR-URL: https://github.com/nodejs/node/pull/44958 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 0cccb6f27d78Michaël Zasso2022-10-112-0/+2
| | | | | | | | | | | | | | | | | | | | | | | Original commit message: [msvc] fix missing include <optional> clang/clang-cl compiled happily (probably included transitively this header), but not MSVC. Bug: v8:13312 Change-Id: I69b6c15f76d8ef13e4fac33f733717429ba96f71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3913033 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#83402} Refs: https://github.com/v8/v8/commit/0cccb6f27d784d835447b210e27224cde89c0011 PR-URL: https://github.com/nodejs/node/pull/44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>