summaryrefslogtreecommitdiff
path: root/test/internet
Commit message (Collapse)AuthorAgeFilesLines
* dns: expose getDefaultResultOrderbtea2023-04-261-0/+24
| | | | | | PR-URL: https://github.com/nodejs/node/pull/46973 Fixes: https://github.com/nodejs/node/issues/46919 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
* net: enable autoSelectFamily by defaultPaolo Insogna2023-04-051-4/+0
| | | | | | | | | | | Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/46790 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* test: move `test-tls-autoselectfamily-servername` to `test/internet`Antoine du Hamel2023-03-111-0/+38
| | | | | | | | | | | And switch from `google.com` to `nodejs.org`. PR-URL: https://github.com/nodejs/node/pull/47029 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* test: fix assertions in test-snapshot-dns-lookup*Tobias Nießen2023-02-181-2/+2
| | | | | | | | | | | | | | | Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: https://github.com/nodejs/node/pull/44633 PR-URL: https://github.com/nodejs/node/pull/46618 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: add trailing commas in `test/internet`Antoine du Hamel2023-02-0117-56/+56
| | | | | PR-URL: https://github.com/nodejs/node/pull/46407 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* test: update uses of _jabber._tcp.google.comcjihrig2022-11-151-2/+2
| | | | | | | | | | | | | _jabber._tcp.google.com seems to have stopped working. This commit changes the host to _caldav._tcp.google.com. Refs: https://github.com/denoland/deno_std/pull/2881 PR-URL: https://github.com/nodejs/node/pull/45451 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* dns: support dns module in the snapshotJoyee Cheung2022-09-292-0/+70
| | | | | | | | | | | | For the initial iteration, only the default resolver can be serialized/deserialized. If `dns.setServers()` has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots. PR-URL: https://github.com/nodejs/node/pull/44633 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* net,tls: pass a valid socket on `tlsClientError`Daeyeon Jeong2022-08-011-0/+31
| | | | | | | | | | | | | On the 'tlsClientError' event, the `tlsSocket` instance is passed as `closed` status. Thus, users can't get information such as `remote address`, `remoteFamily`, and so on. This adds a flag to close a socket after emitting an `error` event. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44021 Fixes: https://github.com/nodejs/node/issues/43963 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* test: fix `internet/test-inspector-help-page`Daeyeon Jeong2022-07-311-1/+1
| | | | | | | | | | | | This gets the test to use its own `https.agent` instead of the default one. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44025 Refs: https://github.com/nodejs/node/pull/43522 Refs: https://github.com/nodejs/node/actions/workflows/test-internet.yml Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* dns: accept `'IPv4'` and `'IPv6'` for `family`Antoine du Hamel2022-06-155-5/+5
| | | | | | | | | | | | | | Refs: https://github.com/nodejs/node/issues/43014 PR-URL: https://github.com/nodejs/node/pull/43054 Fixes: https://github.com/nodejs/node/issues/43014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercionAntoine du Hamel2022-04-121-10/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/41431 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* net: make `server.address()` return an integer for `family`Antoine du Hamel2022-04-125-4/+6
| | | | | | | | | `dns.lookup` options only accepts integer for `family` options, having a string doesn't really make sense here. PR-URL: https://github.com/nodejs/node/pull/41431 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* test: enable no-empty ESLint ruleRich Trott2022-02-054-4/+12
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41831 Refs: https://eslint.org/docs/rules/no-empty Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: do not run `test-corepack-yarn-install` with no internetAntoine du Hamel2021-09-181-0/+64
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* dns: runtime deprecate type coercion of `dns.lookup` optionsAntoine du Hamel2021-09-151-0/+15
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* test: fix internet/test-dnsRich Trott2021-09-111-1/+1
| | | | | | | | | | internet/test-dns is failing due to a typo that inadvertently sends a boolean instead of a regular expression. PR-URL: https://github.com/nodejs/node/pull/40083 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* test: use `assert.match` instead of `regexp.test`Michaël Zasso2021-08-313-5/+5
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39928 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* test: remove obsolete TLS testRich Trott2021-06-131-13/+0
| | | | | | | | | | | | | | | The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45b5958d7be95d5aec8de934526c36a7b12 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: https://github.com/nodejs/node/pull/39001 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test: fix flaky test-dns and test-dns-lookupRich Trott2021-04-182-36/+36
| | | | | | | | | | | | | Ubuntu 16.04 is going to be unsupported after April 2021. Switching Node.js CI to Ubuntu 18.04 for the internet tests resulted in failures in test-dns and test-dns-lookup because it returns server failure/try again on .invalid domain. Add a hostname for testing that will return record not found. PR-URL: https://github.com/nodejs/node/pull/38282 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* test: fixup failing test/internet/test-dns.jsJames M Snell2021-04-161-2/+2
| | | | | | | | | | | | | | The `ttl` for the `nodejs.org` DNS record is returning `0` currently. The test checks for `> 0`, causing the test to fail. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38241 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: prepare for consistent comma-dangle lint ruleRich Trott2021-04-016-6/+6
| | | | | | | | | Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: https://github.com/nodejs/node/pull/37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
* test: fix error in test/internet/test-dns.jsRich Trott2020-11-051-1/+2
| | | | | | | | | | Refs: https://github.com/nodejs/node/pull/35466#issuecomment-721936009 PR-URL: https://github.com/nodejs/node/pull/35969 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: add common.mustSucceedTobias Nießen2020-10-174-48/+22
| | | | | | PR-URL: https://github.com/nodejs/node/pull/35086 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* net: add support for resolving DNS CAA recordsDanny Sonnenschein2020-10-162-0/+40
| | | | | | | | | | This adds support for DNS Certification Authority Authorization (RFC 8659) to Node.js. PR-URL: https://github.com/nodejs/node/pull/35466 Fixes: https://github.com/nodejs/node/issues/19239 Refs: https://github.com/nodejs/node/issues/14713 Reviewed-By: Anna Henningsen <anna@addaleax.net>
* test: adjust comments for upcoming lint ruleRich Trott2020-10-072-27/+25
| | | | | | | | | Enforce `//` for multiline comments. Some tests mixed and matched, and at least one did so in a (to me) surprising way. PR-URL: https://github.com/nodejs/node/pull/35485 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* lib: remove ERR_INVALID_OPT_VALUE and ERR_INVALID_OPT_VALUE_ENCODINGDenys Otrishko2020-09-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | This will be a start to generalize all argument validation errors. As currently we throw ARG/OPT, OUT_OF_RANGE, and other more specific errors. The OPT errors didn't bring much to the errors as it's just another variant of ARG error which is sometimes more confusing (some of our code used OPT errors to denote just argument validation errors presumably because of similarity of OPT to 'option' and not 'options-object') and they don't specify the name of the options object where the invalid value is located. Much better approach would be to just specify path to the invalid value in the name of the value as it is done in this PR (i.e. 'options.format', 'options.publicKey.type' etc) Also since this decreases a variety of errors we have it'd be easier to reuse validation code across the codebase. Refs: https://github.com/nodejs/node/pull/31251 Refs: https://github.com/nodejs/node/pull/34070#discussion_r467251009 Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34682 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: make test-tls-reuse-host-from-socket pass without internetRich Trott2020-08-291-37/+0
| | | | | | | | | Start up a TLS server on localhost rather than using example.org. PR-URL: https://github.com/nodejs/node/pull/34953 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: use `.then(common.mustCall())` for all async IIFEsAnna Henningsen2020-07-203-5/+5
| | | | | | | | | | | | This makes sure that all async functions finish as expected. PR-URL: https://github.com/nodejs/node/pull/34363 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: mark test-dgram-multicast-ssmv6-multi-process flakyAshCripps2020-05-221-0/+26
| | | | | | | | | | | | refs: https://github.com/nodejs/node/issues/32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file PR-URL: https://github.com/nodejs/node/pull/33498 Refs: https://github.com/nodejs/node/issues/32946 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: fix test-dns-idna2008Rich Trott2020-05-151-19/+25
| | | | | | | | | The DNS server will sometimes return an IPv6 address (as seen in nightly CI from time to time). Use `family` option to force IPv4. PR-URL: https://github.com/nodejs/node/pull/33367 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* http2: wait for secureConnect before initializingbcoe2020-04-221-0/+80
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/32958 Fixes: https://github.com/nodejs/node/issues/32922 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* test: fix flaky test-dns-any.jsRich Trott2020-03-021-22/+0
| | | | | | | | | | | Remove google.com from domains tested with ANY queries. Fixes: https://github.com/nodejs/node/issues/31721 PR-URL: https://github.com/nodejs/node/pull/32017 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: improve assertion message in test-dns-anyRich Trott2020-02-101-3/+4
| | | | | | | | | | | | | | | | | Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in nightly master branch CI but generally passes. It may prove helpful to know what record types were missing. (All of them? Just one? Something else?) PR-URL: https://github.com/nodejs/node/pull/31697 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: refactor common.expectsErrorRuben Bridgewater2019-12-311-5/+5
| | | | | | | | | | | | | | | | | | | | | | | This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* errors: improve ERR_INVALID_ARG_TYPERuben Bridgewater2019-12-201-1/+1
| | | | | | | | | | | | | | ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: refactor test-dgram-multicast-set-interface-lo.jsTaylor Gagne2019-11-211-16/+17
| | | | | | | | | Convert functions to arrow functions. Remove unused param('signal') from function. PR-URL: https://github.com/nodejs/node/pull/30536 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* test: move test not requiring internet from internet to parallelRich Trott2019-11-211-37/+0
| | | | | | | | | | test-dgram-send-cb-quelches-error works with or without a network. Move to `parallel` directory. PR-URL: https://github.com/nodejs/node/pull/30545 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: use reserved .invalid TLD for invalid address in testRich Trott2019-11-211-1/+1
| | | | | | | | | | | | | RFC 2606 reserves ithe .invalid top-level-domain for use in "domain names that are sure to be invalid and which it is obvious at a glance are invalid." Replace `dne.example.com` which actually isn't guaranteed to not exist. (example.com is for examples, but at least one address does in fact exist in that TLD.) PR-URL: https://github.com/nodejs/node/pull/30545 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: improve assertion message in internet dgram testRich Trott2019-11-211-1/+1
| | | | | | | | | When an error occurs unexpectedly, let the user know what the error is. PR-URL: https://github.com/nodejs/node/pull/30545 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: make doctool work if no internet availableRichard Lau2019-11-051-59/+0
| | | | | | | | | | | | | | Allow doctool to fallback to use local files if not building a release build. PR-URL: https://github.com/nodejs/node/pull/30214 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* dgram: add source-specific multicast supportLucas Pardue2019-10-172-0/+458
| | | | | | | | | | | This adds RFC 4607 support for IPv4 and IPv6. Co-Authored-By: Nicolas Thumann <46975855+n-thumann@users.noreply.github.com> Co-Authored-By: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/15735 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* lib: correct error.errno to always be numericJoyee Cheung2019-06-171-20/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | Historically `error.errno` of system errors thrown by Node.js can sometimes be the same as `err.code`, which are string representations of the error numbers. This is useless and incorrect, and results in an information loss for users since then they will have to resort to something like `process.binding('uv'[`UV_${errno}`])` to get to the numeric error codes. This patch corrects this behavior by always setting `error.errno` to be negative numbers. For fabricated errors like `ENOTFOUND`, `error.errno` is now undefined since there is no numeric equivalent for them anyway. For c-ares errors, `error.errno` is now undefined because the numeric representations (negated) can be in conflict with libuv error codes - this is fine since numeric codes was not available for c-ares errors anyway. Users can use the public API `util.getSystemErrorName(errno)` to retrieve string codes for these numbers. PR-URL: https://github.com/nodejs/node/pull/28140 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* doc,tools: get altDocs versions from CHANGELOG.mdRichard Lau2019-06-011-0/+59
| | | | | | | | | Parse `CHANGELOG.md` for versions of Node.js used by the documentation feature `View another version` so that we don't have to manually update the list when we cut a new version or transition a release to LTS. PR-URL: https://github.com/nodejs/node/pull/27661 Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: use common.PORT instead of an extraneous variableBenjamin Ki2019-05-131-5/+3
| | | | | | | | | | | | | This test is not parallelized and so we can use the test commons PORT variable. Refs: https://github.com/nodejs/node/pull/27565#discussion_r281000162 PR-URL: https://github.com/nodejs/node/pull/27565 Fixes: https://github.com/nodejs/node/issues/27341 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: move dgram invalid host test to internet testsBenjamin Ki2019-05-131-0/+21
| | | | | | | | | | | | | | This moves a dgram test from `parallel` to `internet` because it relies on a DNS request. In certain cases, ISPs hijack invalid IETF-reserved invalid names which causes a false negative failure. Fixes: https://github.com/nodejs/node/issues/27341 PR-URL: https://github.com/nodejs/node/pull/27565 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: fix test-dns-idna2008.jsRich Trott2019-04-141-2/+12
| | | | | | | | | | | | | | The test should pass if ESERVFAIL is the result. Refs: https://github.com/nodejs/node/issues/25870#issuecomment-471024667 PR-URL: https://github.com/nodejs/node/pull/27208 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: refactor test-dgram-broadcast-multi-processRich Trott2019-03-231-22/+18
| | | | | | | | | | * Add check that `signal` is not null in callback. * Use arrow functions for callbacks, destructuring where appropriate, and a trailing comma in multi-line arrays PR-URL: https://github.com/nodejs/node/pull/26846 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test: fix syntax error in test-dns-idna2008.js when failingRefael Ackermann2019-03-121-3/+5
| | | | | | | | | | | | | Fixes a bug I introduced in 961322178d69325a46dbcbaea1da818fff12c45a PR-URL: https://github.com/nodejs/node/pull/26570 Refs: https://github.com/nodejs/node/issues/25870 Refs: https://github.com/nodejs/node/pull/26473 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* benchmark,doc,lib,test: capitalize commentsRuben Bridgewater2019-03-101-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/26483 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* test: de-flake test-dns-idna2008.jsRefael Ackermann2019-03-091-9/+27
| | | | | | | | | | | * use known well-behaved DNS server * force pass on ESERVFAIL PR-URL: https://github.com/nodejs/node/pull/26473 Fixes: https://github.com/nodejs/node/issues/25870 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
View Lorry Controller Status