summaryrefslogtreecommitdiff
path: root/vcbuild.bat
Commit message (Collapse)AuthorAgeFilesLines
* tools: remove targets for individual test suites in `Makefile`Antoine du Hamel2023-03-311-6/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46892 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* msi: migrate to WiX4Stefan Stojanovic2023-03-221-27/+1
| | | | | | | | | To be able to build x86, x64, and ARM64 MSI installers with the same WiX version, migration to WiX4 is required. PR-URL: https://github.com/nodejs/node/pull/45943 Refs: https://github.com/nodejs/build/issues/2540 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* build: fix Visual Studio installation detection for Arm64Radek Bartoň2023-03-021-5/+5
| | | | | PR-URL: https://github.com/nodejs/node/pull/46420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* build: fix arm64 cross-compile from powershellStefan Stojanovic2022-12-241-2/+2
| | | | | | | | Starting vcbuild.bat for cross-compiling from powershell was failing the licensertf step because it couldn't find x64_node_exe after downloading. PR-URL: https://github.com/nodejs/node/pull/45890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* build: add option to disable shared readonly heapAnna Henningsen2022-12-211-0/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45887 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build,deps,src: fix Intel VTune profiling supportShi Lei2022-11-221-1/+5
| | | | | PR-URL: https://github.com/nodejs/node/pull/45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* build,win: pass --debug-nghttp2 to configureSantiago Gimeno2022-11-011-0/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45209 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* build: remove dtrace & etw supportBen Noordhuis2022-07-171-10/+2
| | | | | | | | | | | | | | | | There are no clear indicators anyone is using the dtrace USDT probes. ETW support is very intertwined with the dtrace infrastructure. It's not clear if anyone uses ETW so to keep things simple it too is removed. Fixes: https://github.com/nodejs/node/issues/43649 PR-URL: https://github.com/nodejs/node/pull/43652 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
* tools: refactor `tools/license2rtf` to ESMFeng Yu2022-07-081-5/+5
| | | | | | | | | | This reverts commit 331088f4a450e29f3ea8a28a9f98ccc9f8951386. PR-URL: https://github.com/nodejs/node/pull/43232 Refs: https://github.com/nodejs/node/issues/43213 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* build: add nonpm and nocorepack to vcbuild.batDarshan Sen2022-06-021-17/+30
| | | | | | | | | | | | The `./configure` script allows you to produce a build without npm and corepack with the `--without-npm` and `--without-corepack` options respectively, so this change adds the same capability to the `vcbuild.bat` script. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/43219 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* Revert "tools: refactor `tools/license2rtf` to ESM"Richard Lau2022-05-261-2/+2
| | | | | | | | | | | This reverts commit 30cb1bf8b8594e3ec8aa9b9b7a7220fe1cc9c926. PR-URL: https://github.com/nodejs/node/pull/43214 Fixes: https://github.com/nodejs/node/issues/43213 Refs: https://github.com/nodejs/node/pull/43101 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: refactor `tools/license2rtf` to ESMFeng Yu2022-05-251-2/+2
| | | | | | PR-URL: https://github.com/nodejs/node/pull/43101 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: refactor build-addons.js to ESMFeng Yu2022-05-221-3/+3
| | | | | PR-URL: https://github.com/nodejs/node/pull/43099 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* build: fix various shared library build issuesWilliam Marlow2022-05-061-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Node.js unofficially supports a shared library variant where the main node executable is a thin wrapper around node.dll/libnode.so. The key benefit of this is to support embedding Node.js in other applications. Since Node.js 12 there have been a number of issues preventing the shared library build from working correctly, primarily on Windows: * A number of functions used executables such as `mksnapshot` are not exported from `libnode.dll` using a `NODE_EXTERN` attribute * A dependency on the `Winmm` system library is missing * Incorrect defines on executable targets leads to `node.exe` claiming to export a number of functions that are actually in `libnode.dll` * Because `node.exe` attempts to export symbols, `node.lib` gets generated causing native extensions to try to link against `node.exe` not `libnode.dll`. * Similarly, because `node.dll` was renamed to `libnode.dll`, native extensions don't know to look for `libnode.lib` rather than `node.lib`. * On macOS an RPATH is added to find `libnode.dylib` relative to `node` in the same folder. This works fine from the `out/Release` folder but not from an installed prefix, where `node` will be in `bin/` and `libnode.dylib` will be in `lib/`. * Similarly on Linux, no RPATH is added so LD_LIBRARY_PATH needs setting correctly for `bin/node` to find `lib/libnode.so`. For the `libnode.lib` vs `node.lib` issue there are two possible options: 1. Ensure `node.lib` from `node.exe` does not get generated, and instead copy `libnode.lib` to `node.lib`. This means addons compiled when referencing the correct `node.lib` file will correctly depend on `libnode.dll`. The down side is that native addons compiled with stock Node.js will still try to resolve symbols against node.exe rather than libnode.dll. 2. After building `libnode.dll`, dump the exports using `dumpbin`, and process this to generate a `node.def` file to be linked into `node.exe` with the `/DEF:node.def` flag. The export entries in `node.def` will all read ``` my_symbol=libnode.my_symbol ``` so that `node.exe` will redirect all exported symbols back to `libnode.dll`. This has the benefit that addons compiled with stock Node.js will load correctly into `node.exe` from a shared library build, but means that every embedding executable also needs to perform this same trick. I went with the first option as it is the cleaner of the two solutions in my opinion. Projects wishing to generate a shared library variant of Node.js can now, for example, ``` .\vcbuild dll package vs ``` to generate a full node installation including `libnode.dll`, `Release\node.lib`, and all the necessary headers. Native addons can then be built against the shared library build easily by specifying the correct `nodedir` option. For example ``` >npx node-gyp configure --nodedir C:\Users\User\node\Release\node-v18.0.0-win-x64 ... >npx node-gyp build ... >dumpbin /dependents build\Release\binding.node Microsoft (R) COFF/PE Dumper Version 14.29.30136.0 Copyright (C) Microsoft Corporation. All rights reserved. Dump of file build\Release\binding.node File Type: DLL Image has the following dependencies: KERNEL32.dll libnode.dll VCRUNTIME140.dll api-ms-win-crt-string-l1-1-0.dll api-ms-win-crt-stdio-l1-1-0.dll api-ms-win-crt-runtime-l1-1-0.dll ... ``` PR-URL: https://github.com/nodejs/node/pull/41850 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* build: windows/arm64 native compilation supportNiyas Sait2022-04-051-1/+0
| | | | | | | | | | | | Added support for detecting ARM64 host architecture for windows and avoid explicit cross-compilation flag for win/arm64 target as configure.py can auto-detect configuration from host and target architecture. Refs: https://github.com/nodejs/build/issues/2540 PR-URL: https://github.com/nodejs/node/pull/42408 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* tools: use jsdoc recommended rulesRich Trott2021-12-041-1/+1
| | | | | | | | | | | | | | | Enable all recommended JSDoc linting rules and disable the ones we don't (yet?) meet. They can be enabled one by one by removing the lines that turn them off. This requires adding --max-warnings to the ESLint invocations in Makefile and vcbuild.bat because the preset enables the recommended rules as warnings and not errors. PR-URL: https://github.com/nodejs/node/pull/41057 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* build: remove legacy -J test.py option from Makefile/vcbuildRich Trott2021-11-271-5/+5
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/40945 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* tools: implement markdown formattingRich Trott2021-09-251-0/+14
| | | | | | | | | Markdown formatter is now available via `mark format-md` (or `vcbuild format-md` on Windows). PR-URL: https://github.com/nodejs/node/pull/40181 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
* tools: re-implement lint-md without unified-argsRich Trott2021-09-251-1/+1
| | | | | | | | | | | | | | | | | | `unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`. PR-URL: https://github.com/nodejs/node/pull/40180 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: add support for Visual Studio 2022Michaël Zasso2021-09-011-1/+43
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39857 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: add corepackMaël Nison2021-08-251-0/+6
| | | | | | | | | | | | | Corepack provides shims for Yarn and pnpm in order to soften the developer experience when working on Node projects. Refs: https://github.com/nodejs/node/issues/15244 Refs: https://github.com/nodejs/TSC/issues/904 PR-URL: https://github.com/nodejs/node/pull/39608 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: fix markdown lintingRich Trott2021-08-221-1/+1
| | | | | | | | | | | | | | This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: https://github.com/nodejs/node/pull/39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* build: reconfigure when gyp files change on WindowsJoyee Cheung2021-06-211-2/+2
| | | | | | | | | | Previously only changes to .gypi files trigger a reconfigure on Windows. PR-URL: https://github.com/nodejs/node/pull/39066 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* Revert "build: work around bug in MSBuild v16.10.0"Michaël Zasso2021-06-151-2/+0
| | | | | | | | | | | | | | This reverts commit 3457130eb623dff8c40315401485fc368aad5bc1. Visual Studio v16.10.1 is out. Closes: https://github.com/nodejs/node/issues/38872 PR-URL: https://github.com/nodejs/node/pull/38977 Fixes: https://github.com/nodejs/node/issues/38872 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: update doctool dependencies, migrate to ESMMichaël Zasso2021-06-141-2/+2
| | | | | | | | | | | | | | | | | | | - Migrated to ESM because some dependencies now require it. - Did not update `highlight.js` to v11 because it has many breaking changes. - Used non-deprecated `highlight.js` API. Refs: https://github.com/highlightjs/highlight.js/issues/2277 Fixes: https://github.com/nodejs/node/issues/38938 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38966 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* build: work around bug in MSBuild v16.10.0Michaël Zasso2021-06-011-0/+2
| | | | | | | | | | | | | | | This allows to build Node.js at the (temporary) cost of longer build times. Refs: https://github.com/nodejs/node/issues/38872 Refs: https://github.com/dotnet/msbuild/releases/tag/v16.10.0 Refs: https://github.com/dotnet/msbuild/pull/6465 Refs: https://github.com/dotnet/msbuild/issues/6373 PR-URL: https://github.com/nodejs/node/pull/38873 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
* doc: use `HEAD` instead of `master` for linksAntoine du Hamel2021-05-051-1/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38518 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* build: add pummel tests to ci runsRich Trott2021-04-101-1/+1
| | | | | PR-URL: https://github.com/nodejs/node/pull/34289 Reviewed-By: Richard Lau <rlau@redhat.com>
* tools: update eslint-plugin-markdown configurationcjihrig2021-03-031-1/+1
| | | | | | | | | | | This commit updates the linting setup to work with eslint-plugin-markdown@2.0.0. This also allows the update-eslint script to continue to function properly without changes. PR-URL: https://github.com/nodejs/node/pull/37549 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* quic: remove quicJames M Snell2021-01-301-4/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37067 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* win,build,tools: support VS prereleaseBaruch Odem2020-11-201-1/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/36033 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: conditionally clear vcinstalldirBrian Ingenito2020-11-131-1/+1
| | | | | | | | | | | | For scenario where target env is explicitly specified as vs2019, do not clear VCINSTALLDIR which was being cleared to handle fallback to vs2017 block when attempting to find a matching available VS. Fixes: https://github.com/nodejs/node/issues/35856 PR-URL: https://github.com/nodejs/node/pull/36009 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* win, build: fix build time on WindowsBartosz Sosnowski2020-11-071-0/+4
| | | | | | | | | | | | | | | | Sets MSBuild experimental switches to make it build in parallel project files generated by gyp 0.5.0. Fixes: https://github.com/nodejs/node/issues/35921 PR-URL: https://github.com/nodejs/node/pull/35932 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build: add vcbuilt test-doc targetAntoine du Hamel2020-10-301-1/+2
| | | | | | PR-URL: https://github.com/nodejs/node/pull/35708 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* build,win: use x64 Node when building for ARM64Dennis Ameling2020-08-201-1/+20
| | | | | | | | | | | | Uses x64 node executable for running .js files in arm64 cross-compilation scenarios. MSI can now be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/34009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
* build: fix test-ci-js task in MakefileRich Trott2020-07-221-2/+2
| | | | | | | | | | Move benchmark CI to native suite since it requires building an addon. Refs: https://github.com/nodejs/node/issues/34427#issuecomment-660760789 PR-URL: https://github.com/nodejs/node/pull/34433 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* build: do not run benchmark tests on 'make test'Rich Trott2020-07-221-3/+5
| | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/34427 PR-URL: https://github.com/nodejs/node/pull/34434 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: add benchmark tests to CI runsRich Trott2020-07-131-1/+1
| | | | | | | | Closes: https://github.com/nodejs/node/issues/34321 PR-URL: https://github.com/nodejs/node/pull/34288 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
* tools: remove lint-js.jsRich Trott2020-07-031-9/+1
| | | | | | | | | | | | | | | | | | | | | | lint-js.js was implemented before ESLint had a caching feature. It is now only used in CI. Let's remove it on the following grounds: * It results in occasional (and puzzling) yellow CI runs for node-test-linter because the tap file is corrupted somehow. Interleaved maybe? I don't know, but a simple solution is removing it and running ESLint directly. * On my local laptop, it reduces the linting from about 75 seconds to about 55 seconds. This kind of savings is not worth the added complexity and the instability noted above. PR-URL: https://github.com/nodejs/node/pull/30955 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* quic: initial QUIC implementationJames M Snell2020-06-161-1/+4
| | | | | | | | | | | | | | | Co-authored-by: Anna Henningsen <anna@addaleax.net> Co-authored-by: Daniel Bevenius <daniel.bevenius@gmail.com> Co-authored-by: gengjiawen <technicalcute@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Lucas Pardue <lucaspardue.24.7@gmail.com> Co-authored-by: Ouyang Yadong <oyydoibh@gmail.com> Co-authored-by: Juan Jos<C3><A9> Arboleda <soyjuanarbol@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Denys Otrishko <shishugi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32379 Reviewed-By: Anna Henningsen <anna@addaleax.net>
* build: drop support for VS2017Michaël Zasso2020-06-121-44/+6
| | | | | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/33694 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
* build,win: add support for MSVC cross-compilationRichard Townsend2020-05-191-0/+1
| | | | | | | | | | | * Fixes cases in icutools where commands were issued without .exe * Changes to build scripts * Add /fp:strict flag so that MSVC's floating point behaves correctly * Enables marmasm PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>
* Revert "src: add test/abort build tasks"Richard Lau2020-05-061-26/+4
| | | | | | | | | | This reverts commit e08ac095690015a8c488e05251e05feb2acc57a0. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* build: fix vcbuild error for missing Visual StudioThomas2020-04-281-1/+1
| | | | | | | | | | | | | | The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio. PR-URL: https://github.com/nodejs/node/pull/32658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* win,build: set exit_code on configure failureBartlomiej Brzozowski2020-03-301-0/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/32205 Fixes: https://github.com/nodejs/node/issues/31573 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: add test/abort build tasksChristian Niederer2020-03-301-4/+26
| | | | | | | | | | | | The Aliased*Array overflow check test introduced a dependency to a compiled artifact. Add this artifact to the build process in a similar fashion as test/addons and test/js-native-api do. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* build: remove enable_vtune from vcbuild.batRichard Lau2020-01-151-5/+1
| | | | | | | | | | vcbuild.bat wasn't updated when vtune support was removed in https://github.com/nodejs/node/pull/28522 Refs: https://github.com/nodejs/node/pull/28522 PR-URL: https://github.com/nodejs/node/pull/31338 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build: add vs2019 to vcbuild.bat helpRichard Lau2020-01-151-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/31338 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build,win: fix goto exit in vcbuildJoão Reis2019-12-141-0/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/30931 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* build,win: support building MSI with VS2019João Reis2019-12-131-3/+5
| | | | | | | | | | | Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible. PR-URL: https://github.com/nodejs/node/pull/30895 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
View Lorry Controller Status