397832 - libpkix leaks memory if a macro calls a function that returns an error.patch 391719. r=nelson

1 files changed, 5 insertions, 2 deletions

diff --git a/security/nss/lib/libpkix/pkix/results/pkix_verifynode.c b/security/nss/lib/libpkix/pkix/results/pkix_verifynode.c
index 1b3c79af3..4591945bc 100755
--- a/security/nss/lib/libpkix/pkix/results/pkix_verifynode.c
+++ b/security/nss/lib/libpkix/pkix/results/pkix_verifynode.c
@@ -94,17 +94,20 @@ pkix_VerifyNode_Create(
         PKIX_INCREF(cert);
         node->verifyCert = cert;
 
-        node->depth = depth;
-
         PKIX_INCREF(error);
         node->error = error;
 
+        node->depth = depth;
+
         node->children = NULL;
 
         *pObject = node;
+        node = NULL;
 
 cleanup:
 
+        PKIX_DECREF(node);
+
         PKIX_RETURN(VERIFYNODE);
 }