Bug 1738600 - sunset Coverity from NSS. r=nss-reviewers,bbeurdouche

Differential Revision: https://phabricator.services.mozilla.com/D129982

5 files changed, 2 insertions, 56 deletions

diff --git a/automation/taskcluster/docker-fuzz/Dockerfile b/automation/taskcluster/docker-fuzz/Dockerfile
index 00964b42f..d7e7fa918 100644
--- a/automation/taskcluster/docker-fuzz/Dockerfile
+++ b/automation/taskcluster/docker-fuzz/Dockerfile
@@ -1,5 +1,5 @@
 # Dockerfile for running fuzzing tests.
-# Used for ASAN and Coverity based static-analysis.
+# Used for ASAN.
 # Note that when running this, you need to add `--cap-add SYS_PTRACE` to the
 # docker invocation or ASAN won't work.
 # On taskcluster for ASAN use `features: ["allowPtrace"]`.
diff --git a/automation/taskcluster/graph/src/extend.js b/automation/taskcluster/graph/src/extend.js
index 58b89dc70..ee3710555 100644
--- a/automation/taskcluster/graph/src/extend.js
+++ b/automation/taskcluster/graph/src/extend.js
@@ -1149,33 +1149,6 @@ async function scheduleTools() {
   }));
 
   queue.scheduleTask(merge(base, {
-    symbol: "coverity",
-    name: "coverity",
-    image: FUZZ_IMAGE,
-    tags: ['code-review'],
-    env: {
-      USE_64: "1",
-      CC: "clang",
-      CCC: "clang++",
-      NSS_AUTOMATION: "1"
-    },
-    features: ["taskclusterProxy"],
-    scopes: ["secrets:get:project/relman/coverity-nss"],
-    artifacts: {
-      "public/code-review/coverity.json": {
-        expires: 24 * 7,
-        type: "file",
-        path: "/home/worker/nss/coverity/coverity.json"
-      }
-    },
-    command: [
-      "/bin/bash",
-      "-c",
-      "bin/checkout.sh && nss/automation/taskcluster/scripts/run_coverity.sh"
-    ]
-  }));
-
-  queue.scheduleTask(merge(base, {
     symbol: "hacl",
     name: "hacl",
     image: LINUX_BUILDS_IMAGE,
diff --git a/automation/taskcluster/graph/src/index.js b/automation/taskcluster/graph/src/index.js
index 2c7f5eb50..78f4af8e4 100644
--- a/automation/taskcluster/graph/src/index.js
+++ b/automation/taskcluster/graph/src/index.js
@@ -10,12 +10,6 @@ const main = async () => {
   // Init try syntax filter.
   if (process.env.TC_PROJECT == "nss-try") {
     await try_syntax.initFilter();
-  } else {
-    // Coverity should not be run on landings, only by request (typically
-    // by Phabricator).
-    queue.filter(task => {
-      return task.symbol != "coverity";
-    });
   }
 
   // Extend the task graph.
diff --git a/automation/taskcluster/graph/src/try_syntax.js b/automation/taskcluster/graph/src/try_syntax.js
index 0d2e84c59..4629ff4b2 100644
--- a/automation/taskcluster/graph/src/try_syntax.js
+++ b/automation/taskcluster/graph/src/try_syntax.js
@@ -57,7 +57,7 @@ function parseOptions(opts) {
   }
 
   // Parse tools.
-  let allTools = ["clang-format", "scan-build", "coverity", "hacl", "saw", "abi", "coverage"];
+  let allTools = ["clang-format", "scan-build", "hacl", "saw", "abi", "coverage"];
   let tools = intersect(opts.tools.split(/\s*,\s*/), allTools);
 
   // If the given value is "all" run all tools.
diff --git a/automation/taskcluster/scripts/run_coverity.sh b/automation/taskcluster/scripts/run_coverity.sh
deleted file mode 100755
index 4b09f5398..000000000
--- a/automation/taskcluster/scripts/run_coverity.sh
+++ /dev/null
@@ -1,21 +0,0 @@
-#!/usr/bin/env bash
-
-source $(dirname "$0")/tools.sh
-
-# Clone NSPR if needed.
-if [ ! -d "nspr" ]; then
-    hg_clone https://hg.mozilla.org/projects/nspr ./nspr default
-
-  if [[ -f nss/nspr.patch && "$ALLOW_NSPR_PATCH" == "1" ]]; then
-    pushd nspr
-    cat ../nss/nspr.patch | patch -p1
-    popd
-  fi
-fi
-
-# Build and run Coverity
-cd nss
-./mach static-analysis
-
-# Return the exit code of the Coverity Analysis
-exit $?