summaryrefslogtreecommitdiff
path: root/gtests/freebl_gtest
diff options
context:
space:
mode:
authorRobert Relyea <rrelyea@redhat.com>2020-12-22 10:24:52 -0800
committerRobert Relyea <rrelyea@redhat.com>2020-12-22 10:24:52 -0800
commit7cb0b69737307faa671f8547a7bfb32c44f86c89 (patch)
tree901b82748001c2a19ab5c4c37216c09356909bd2 /gtests/freebl_gtest
parent12aee4d4646e475f3d3e795a1a3f0690520a8723 (diff)
downloadnss-hg-7cb0b69737307faa671f8547a7bfb32c44f86c89.tar.gz
Restore lost portion of the bleichenbacher timing batch that addressed
review comments. All the review comments pertained to actual code comments, so this patch only affects the comments.
Diffstat (limited to 'gtests/freebl_gtest')
-rw-r--r--gtests/freebl_gtest/rsa_unittest.cc12
1 files changed, 6 insertions, 6 deletions
diff --git a/gtests/freebl_gtest/rsa_unittest.cc b/gtests/freebl_gtest/rsa_unittest.cc
index cac685c7e..a896a38d4 100644
--- a/gtests/freebl_gtest/rsa_unittest.cc
+++ b/gtests/freebl_gtest/rsa_unittest.cc
@@ -77,18 +77,18 @@ TEST_F(RSATest, DecryptBlockTestErrors) {
EXPECT_EQ(SECFailure, rv);
uint8_t in[256] = {0};
- // This should fail because the padding checks will fail.
- // however, Bleichenbacher preventions means that failure would be
- // a different output.
+ // This should fail because the padding checks will fail,
+ // however, mitigations for Bleichenbacher attacks transform failures
+ // to a different output.
rv = RSA_DecryptBlock(key.get(), out, &outputLen, maxOutputLen, in,
sizeof(in));
EXPECT_EQ(SECSuccess, rv);
// outputLen should <= 256-11=245.
EXPECT_LE(outputLen, 245u);
- // This should fail because the padding checks will fail.
- // however, Bleichenbacher preventions means that failure would be
- // a different output.
+ // This should fail because the padding checks will fail,
+ // however, mitigations for Bleichenbacher attacks transform failures
+ // to a different output.
uint8_t out_long[260] = {0};
maxOutputLen = sizeof(out_long);
rv = RSA_DecryptBlock(key.get(), out_long, &outputLen, maxOutputLen, in,