diff options
author | Robert Relyea <rrelyea@redhat.com> | 2020-12-22 10:24:52 -0800 |
---|---|---|
committer | Robert Relyea <rrelyea@redhat.com> | 2020-12-22 10:24:52 -0800 |
commit | 7cb0b69737307faa671f8547a7bfb32c44f86c89 (patch) | |
tree | 901b82748001c2a19ab5c4c37216c09356909bd2 /gtests/pk11_gtest | |
parent | 12aee4d4646e475f3d3e795a1a3f0690520a8723 (diff) | |
download | nss-hg-7cb0b69737307faa671f8547a7bfb32c44f86c89.tar.gz |
Restore lost portion of the bleichenbacher timing batch that addressed
review comments. All the review comments pertained to actual code comments,
so this patch only affects the comments.
Diffstat (limited to 'gtests/pk11_gtest')
-rw-r--r-- | gtests/pk11_gtest/pk11_rsaoaep_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gtests/pk11_gtest/pk11_rsaoaep_unittest.cc b/gtests/pk11_gtest/pk11_rsaoaep_unittest.cc index 2e80e6a38..82f3f9fb8 100644 --- a/gtests/pk11_gtest/pk11_rsaoaep_unittest.cc +++ b/gtests/pk11_gtest/pk11_rsaoaep_unittest.cc @@ -166,14 +166,14 @@ TEST(Pkcs11RsaOaepTest, TestOaepWrapUnwrap) { // This assumes CKM_RSA_PKCS and doesn't understand OAEP. // CKM_RSA_PKCS cannot safely return errors, however, as it can lead - // to Blecheinbaucher-like attacks. To solve this there's a new definition + // to Bleichenbacher-like attacks. To solve this there's a new definition // that generates fake key material based on the message and private key. // This returned key material will not be the key we were expecting, so // make sure that's the case: p_unwrapped_tmp = PK11_PubUnwrapSymKey(priv.get(), wrapped.get(), CKM_AES_CBC, CKA_DECRYPT, 16); - // as long as the wrapped data is legal RSA length of the key - // (which is should be), then CKM_RSA_PKCS should not fail. + // As long as the wrapped data is the same length as the key + // (which it should be), then CKM_RSA_PKCS should not fail. ASSERT_NE(p_unwrapped_tmp, nullptr); ScopedPK11SymKey fakeUnwrapped; fakeUnwrapped.reset(p_unwrapped_tmp); |