diff options
| author | Martin Thomson <mt@lowentropy.net> | 2021-12-28 23:25:50 +0000 |
|---|---|---|
| committer | Martin Thomson <mt@lowentropy.net> | 2021-12-28 23:25:50 +0000 |
| commit | c1c587e4e694fd570ae91c340cc46004324bf127 (patch) | |
| tree | acbf374eb055bb745bd3eb00adc8973bf9d4a87f /gtests/ssl_gtest | |
| parent | bcba0393a488eccf59bf53cb388e50e57c23787d (diff) | |
| download | nss-hg-c1c587e4e694fd570ae91c340cc46004324bf127.tar.gz | |
Bug 1747317 - test HKDF output rather than input, r=nss-reviewers,jschanck
Depends on D134557
Differential Revision: https://phabricator.services.mozilla.com/D134558
Diffstat (limited to 'gtests/ssl_gtest')
| -rw-r--r-- | gtests/ssl_gtest/tls_hkdf_unittest.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/gtests/ssl_gtest/tls_hkdf_unittest.cc b/gtests/ssl_gtest/tls_hkdf_unittest.cc index dc6e2aeb6..3e1e30bb8 100644 --- a/gtests/ssl_gtest/tls_hkdf_unittest.cc +++ b/gtests/ssl_gtest/tls_hkdf_unittest.cc @@ -176,6 +176,7 @@ class TlsHkdfTest : public ::testing::Test, const uint8_t* session_hash, size_t session_hash_len, const char* label, size_t label_len, const DataBuffer& expected) { + ASSERT_NE(nullptr, prk); std::cerr << "Hash = " << kHashName[base_hash] << std::endl; std::vector<uint8_t> output(expected.len()); @@ -194,7 +195,7 @@ class TlsHkdfTest : public ::testing::Test, session_hash, session_hash_len, label, label_len, &secret); EXPECT_EQ(SECSuccess, rv); - ASSERT_NE(nullptr, prk); + ASSERT_NE(nullptr, secret); VerifyKey(ScopedPK11SymKey(secret), CKM_HKDF_DERIVE, expected); // Verify that a key can be created with a different key type and size. @@ -202,7 +203,7 @@ class TlsHkdfTest : public ::testing::Test, SSL_LIBRARY_VERSION_TLS_1_3, cs, prk->get(), session_hash, session_hash_len, label, label_len, CKM_DES3_CBC_PAD, 24, &secret); EXPECT_EQ(SECSuccess, rv); - ASSERT_NE(nullptr, prk); + ASSERT_NE(nullptr, secret); ScopedPK11SymKey with_mech(secret); EXPECT_EQ(static_cast<CK_MECHANISM_TYPE>(CKM_DES3_CBC_PAD), PK11_GetMechanism(with_mech.get())); |