Bug 1277228 - some scan-build fixes to enable it on base/certdb/certhigh, r=ttaubert

try: -t all

1 files changed, 1 insertions, 4 deletions

diff --git a/lib/base/list.c b/lib/base/list.c
index a36cdb1b3..e798cf09c 100644
--- a/lib/base/list.c
+++ b/lib/base/list.c
@@ -52,20 +52,17 @@ pointer_compare(void *a, void *b)
 static nssListElement *
 nsslist_get_matching_element(nssList *list, void *data)
 {
-    PRCList *link;
     nssListElement *node;
     node = list->head;
     if (!node) {
         return NULL;
     }
-    link = &node->link;
     while (node) {
         /* using a callback slows things down when it's just compare ... */
         if (list->compareFunc(node->data, data)) {
             break;
         }
-        link = &node->link;
-        if (link == PR_LIST_TAIL(&list->head->link)) {
+        if (&node->link == PR_LIST_TAIL(&list->head->link)) {
             node = NULL;
             break;
         }