diff options
| author | Wan-Teh Chang <wtc@google.com> | 2015-08-22 08:23:26 -0700 |
|---|---|---|
| committer | Wan-Teh Chang <wtc@google.com> | 2015-08-22 08:23:26 -0700 |
| commit | 9129ebf8c0bc1a1e444770c926efb2941c653ce7 (patch) | |
| tree | cc1ab1c68e6cf3932db3acbfc39baabef432dbe3 /lib/libpkix | |
| parent | 54bac6a7e1f1021b04b6d7d01e0d3005fc5b0955 (diff) | |
| download | nss-hg-9129ebf8c0bc1a1e444770c926efb2941c653ce7.tar.gz | |
Bug 1182667: Remove the statement that assigns an enum value (int) to
the |data| member (unsigned char *) of a SECItem.
This statement causes a compiler warning. It actually has no effect
because the pkix_pl_LdapDefaultClient_VerifyBindResponse call overwrites
the |msg| structure when it returns rv=SECSuccess, and we only inspect
|msg| when rv == SECSuccess. Here is the compiler warning generated by
clang on Mac OS X:
pkix_pl_ldapdefaultclient.c:365:59: error: incompatible integer to pointer
conversion assigning to 'unsigned char *' from 'int'
[-Werror,-Wint-conversion]
msg.protocolOp.op.bindResponseMsg.resultCode.data = OTHER;
^ ~~~~~
TBR=mt
Diffstat (limited to 'lib/libpkix')
| -rw-r--r-- | lib/libpkix/pkix_pl_nss/module/pkix_pl_ldapdefaultclient.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/libpkix/pkix_pl_nss/module/pkix_pl_ldapdefaultclient.c b/lib/libpkix/pkix_pl_nss/module/pkix_pl_ldapdefaultclient.c index 6d7380c62..a191ad65d 100644 --- a/lib/libpkix/pkix_pl_nss/module/pkix_pl_ldapdefaultclient.c +++ b/lib/libpkix/pkix_pl_nss/module/pkix_pl_ldapdefaultclient.c @@ -362,7 +362,6 @@ pkix_pl_LdapDefaultClient_VerifyBindResponse( decode.data = (void *)(client->rcvBuf); decode.len = bufLen; - msg.protocolOp.op.bindResponseMsg.resultCode.data = OTHER; PKIX_CHECK(pkix_pl_LdapDefaultClient_DecodeBindResponse (client->arena, &decode, &msg, &rv, plContext), PKIX_LDAPDEFAULTCLIENTDECODEBINDRESPONSEFAILED); |