diff options
| author | Gabriel Scherer <gabriel.scherer@gmail.com> | 2023-03-04 17:00:55 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-04 17:00:55 +0100 |
| commit | d4ace73782bd513067ada628c1fd39ffc08f84d7 (patch) | |
| tree | 4b1cbd65d91945e53dda67a0d2be299eb9e45a77 /testsuite | |
| parent | acbffb596f97927ff91b82ff6e099d5b597512f3 (diff) | |
| download | ocaml-d4ace73782bd513067ada628c1fd39ffc08f84d7.tar.gz | |
intext_par: avoid a sequentiality assumption on object identifiers (#12069)
In presence of concurrent code execution, we cannot assume that two
object creation in sequence will return consecutive integers.
(The testcase was added as a regression test for a case where object
identifiers were all constant after demarshalling. The weaker test
that we propose would also catch this issue if it came back.)
Note: due to the batching of object identifiers, it is in fact very
hard to observe a failure of this test: each domain reserves the next
1024 identifiers, so in most case we observe consecutive identifiers
for the same domain.
Diffstat (limited to 'testsuite')
| -rw-r--r-- | testsuite/tests/lib-marshal/intext_par.ml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/testsuite/tests/lib-marshal/intext_par.ml b/testsuite/tests/lib-marshal/intext_par.ml index 2efb846665..8db6e91a5a 100644 --- a/testsuite/tests/lib-marshal/intext_par.ml +++ b/testsuite/tests/lib-marshal/intext_par.ml @@ -482,7 +482,7 @@ let test_objects () = test 509 (x#test2 = false); test 510 (x#test3 = "footest5test3test442"); test 511 (x#test4 = 42L); - test 512 (Oo.id x = Oo.id x0 + 1) (* PR#5610 *) + test 512 (Oo.id x > Oo.id x0) (* PR#5610 *) (* Test for infix pointers *) let test_infix () = |