diff options
| author | Alain Frisch <alain@frisch.fr> | 2016-08-30 13:11:01 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-08-30 13:11:01 +0200 |
| commit | 227bdc621779842e0199534c8e9b589a1a726ca1 (patch) | |
| tree | 66bd0017785c15f2a1412aa68330db1906c98322 /typing/typemod.mli | |
| parent | a424f0aae15c925f4deb0dadf4fcd6dcf2fae604 (diff) | |
| download | ocaml-227bdc621779842e0199534c8e9b589a1a726ca1.tar.gz | |
Avoid rebuilding cmi_info record when creating .cmti files (#781)
Instead of rebuilding cmi_info in Cmt_format.save_cmt, the record
created in Env.save_signature is kept and passed to that function. In
addition to simplifying the code, this avoids possible mismatch between
the two records, including:
- Duplicated entry in cmi_crcs for the current unit as noted in #744.
- Missing flags (Unsafe_string/Deprecated were not properly set in
Cmt_format).
The interface is also stronger, since the signature passed to save_cmt
was supposed to be already mapped by Subst.for_saving but this was not
reflected in the API.
Diffstat (limited to 'typing/typemod.mli')
| -rw-r--r-- | typing/typemod.mli | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/typing/typemod.mli b/typing/typemod.mli index 40172bccbd..fab7cdae53 100644 --- a/typing/typemod.mli +++ b/typing/typemod.mli @@ -47,7 +47,7 @@ val path_of_module : Typedtree.module_expr -> Path.t option val save_signature: string -> Typedtree.signature -> string -> string -> - Env.t -> Types.signature_item list -> unit + Env.t -> Cmi_format.cmi_infos -> unit val package_units: Env.t -> string list -> string -> string -> Typedtree.module_coercion |