diff options
| author | Mike Christie <michaelc@cs.wisc.edu> | 2008-02-21 15:54:56 -0600 |
|---|---|---|
| committer | Mike Christie <michaelc@cs.wisc.edu> | 2008-02-21 15:54:56 -0600 |
| commit | 24dd289ac1cb5395460e5dfd83f9b9ed927a876a (patch) | |
| tree | 659744443a4a0f569649cf9691e01adeb38a7b8c /include | |
| parent | b11b31ac745ae72c3305a5658c619557000108a3 (diff) | |
| download | open-iscsi-24dd289ac1cb5395460e5dfd83f9b9ed927a876a.tar.gz | |
The session age mask is only 4 bits, but session->age is 32. When
it gets larger then 15 and we try to or the bits some bits get
dropped and the check for session age in iscsi_verify_itt is useless.
The ISCSI_CID_MASK related bits are also useless since cid is always
one.
Diffstat (limited to 'include')
| -rw-r--r-- | include/iscsi_proto.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/iscsi_proto.h b/include/iscsi_proto.h index 6256e37..916c02c 100644 --- a/include/iscsi_proto.h +++ b/include/iscsi_proto.h @@ -60,8 +60,8 @@ /* initiator tags; opaque for target */ typedef uint32_t __bitwise__ itt_t; /* below makes sense only for initiator that created this tag */ -#define build_itt(itt, id, age) ((__force itt_t)\ - ((itt) | ((id) << ISCSI_CID_SHIFT) | ((age) << ISCSI_AGE_SHIFT))) +#define build_itt(itt, age) ((__force itt_t)\ + ((itt) | ((age) << ISCSI_AGE_SHIFT))) #define get_itt(itt) ((__force uint32_t)(itt_t)(itt) & ISCSI_ITT_MASK) #define RESERVED_ITT ((__force itt_t)0xffffffff) |