diff options
author | mnc <mnc@d7303112-9cec-0310-bdd2-e83a94d6c2b6> | 2006-01-19 07:38:52 +0000 |
---|---|---|
committer | mnc <mnc@d7303112-9cec-0310-bdd2-e83a94d6c2b6> | 2006-01-19 07:38:52 +0000 |
commit | 7e2c8f9a7e3af0bbaf2896c4593165cd011ea98a (patch) | |
tree | 47748d0e583a45c2793177d4a111a48c43b3000f /kernel | |
parent | 37cf261f8f11cbd6a97f87426c594e63325b3a9c (diff) | |
download | open-iscsi-7e2c8f9a7e3af0bbaf2896c4593165cd011ea98a.tar.gz |
rm conn lock: it is only used during dataqueue destruction. It appears the the session_lock and xmitmutex and sk_callback lock protect this code
git-svn-id: svn://svn.berlios.de/open-iscsi@468 d7303112-9cec-0310-bdd2-e83a94d6c2b6
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/iscsi_tcp.c | 4 | ||||
-rw-r--r-- | kernel/iscsi_tcp.h | 1 |
2 files changed, 0 insertions, 5 deletions
diff --git a/kernel/iscsi_tcp.c b/kernel/iscsi_tcp.c index 6abe326..c35fbe5 100644 --- a/kernel/iscsi_tcp.c +++ b/kernel/iscsi_tcp.c @@ -244,12 +244,10 @@ iscsi_ctask_cleanup(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask) if (sc->sc_data_direction == DMA_TO_DEVICE) { struct iscsi_data_task *dtask, *n; /* WRITE: cleanup Data-Out's if any */ - spin_lock(&conn->lock); list_for_each_entry_safe(dtask, n, &ctask->dataqueue, item) { list_del(&dtask->item); mempool_free(dtask, ctask->datapool); } - spin_unlock(&conn->lock); } ctask->xmstate = XMSTATE_IDLE; ctask->r2t = NULL; @@ -2453,8 +2451,6 @@ iscsi_conn_create(struct iscsi_cls_session *cls_session, uint32_t conn_idx) conn->data_size = DEFAULT_MAX_RECV_DATA_SEGMENT_LENGTH; conn->max_recv_dlength = DEFAULT_MAX_RECV_DATA_SEGMENT_LENGTH; - spin_lock_init(&conn->lock); - /* initialize general xmit PDU commands queue */ conn->xmitqueue = kfifo_alloc(session->cmds_max * sizeof(void*), GFP_KERNEL, NULL); diff --git a/kernel/iscsi_tcp.h b/kernel/iscsi_tcp.h index 6766b81..ba26741 100644 --- a/kernel/iscsi_tcp.h +++ b/kernel/iscsi_tcp.h @@ -146,7 +146,6 @@ struct iscsi_conn { struct iscsi_mgmt_task *login_mtask; /* mtask used for login/text */ struct iscsi_mgmt_task *mtask; /* xmit mtask in progress */ struct iscsi_cmd_task *ctask; /* xmit ctask in progress */ - spinlock_t lock; /* FIXME: to be removed */ /* old values for socket callbacks */ void (*old_data_ready)(struct sock *, int); |