summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDarren Tucker <dtucker@zip.com.au>2005-03-07 18:35:34 +1100
committerDarren Tucker <dtucker@zip.com.au>2005-03-07 18:35:34 +1100
commit5d909f077336318267d4089f41c7deb5e4b6c64d (patch)
treeec0c2b55e66c7a116e48b8df4994dcec7bd20227
parent894823ec69fbf5249c2d181e74cf42e392c623c3 (diff)
downloadopenssh-git-5d909f077336318267d4089f41c7deb5e4b6c64d.tar.gz
- djm@cvs.openbsd.org 2005/03/04 08:48:46
[Makefile envpass.sh] regress test for SendEnv config parsing bug; ok dtucker@
-rw-r--r--ChangeLog5
-rw-r--r--regress/Makefile4
-rw-r--r--regress/envpass.sh21
3 files changed, 21 insertions, 9 deletions
diff --git a/ChangeLog b/ChangeLog
index 4b481a18..1c02ab32 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -15,6 +15,9 @@
- djm@cvs.openbsd.org 2005/02/27 23:13:36
[login-timeout.sh]
avoid nameservice lookups in regress test; ok dtucker@
+ - djm@cvs.openbsd.org 2005/03/04 08:48:46
+ [Makefile envpass.sh]
+ regress test for SendEnv config parsing bug; ok dtucker@
20050306
- (dtucker) [monitor.c] Bug #125 comment #47: fix errors returned by monitor
@@ -2301,4 +2304,4 @@
- (djm) Trim deprecated options from INSTALL. Mention UsePAM
- (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu
-$Id: ChangeLog,v 1.3699 2005/03/07 07:34:04 dtucker Exp $
+$Id: ChangeLog,v 1.3700 2005/03/07 07:35:34 dtucker Exp $
diff --git a/regress/Makefile b/regress/Makefile
index eee1f3bf..4f47bc3f 100644
--- a/regress/Makefile
+++ b/regress/Makefile
@@ -1,4 +1,4 @@
-# $OpenBSD: Makefile,v 1.35 2005/01/14 04:21:18 david Exp $
+# $OpenBSD: Makefile,v 1.36 2005/03/04 08:48:46 djm Exp $
REGRESS_TARGETS= t1 t2 t3 t4 t5 t6 t7 t-exec
tests: $(REGRESS_TARGETS)
@@ -49,7 +49,7 @@ CLEANFILES= t2.out t6.out1 t6.out2 t7.out t7.out.pub copy.1 copy.2 \
rsa.pub rsa rsa1.pub rsa1 host.rsa host.rsa1 \
rsa-agent rsa-agent.pub rsa1-agent rsa1-agent.pub \
ls.copy banner.in banner.out empty.in \
- scp-ssh-wrapper.scp \
+ scp-ssh-wrapper.scp ssh_proxy_envpass \
remote_pid
#LTESTS += ssh-com ssh-com-client ssh-com-keygen ssh-com-sftp
diff --git a/regress/envpass.sh b/regress/envpass.sh
index 5a7e178d..af7eafe3 100644
--- a/regress/envpass.sh
+++ b/regress/envpass.sh
@@ -1,13 +1,20 @@
-# $OpenBSD: envpass.sh,v 1.3 2004/06/22 22:42:02 dtucker Exp $
+# $OpenBSD: envpass.sh,v 1.4 2005/03/04 08:48:46 djm Exp $
# Placed in the Public Domain.
tid="environment passing"
# NB accepted env vars are in test-exec.sh (_XXX_TEST_* and _XXX_TEST)
+# Prepare a custom config to test for a configuration parsing bug fixed in 4.0
+cat << EOF > $OBJ/ssh_proxy_envpass
+Host test-sendenv-confparse-bug
+ SendEnv *
+EOF
+cat $OBJ/ssh_proxy >> $OBJ/ssh_proxy_envpass
+
trace "pass env, don't accept"
verbose "test $tid: pass env, don't accept"
-_TEST_ENV=blah ${SSH} -oSendEnv="*" -F $OBJ/ssh_proxy otherhost \
+_TEST_ENV=blah ${SSH} -oSendEnv="*" -F $OBJ/ssh_proxy_envpass otherhost \
sh << 'EOF'
test -z "$_TEST_ENV"
EOF
@@ -18,7 +25,7 @@ fi
trace "don't pass env, accept"
verbose "test $tid: don't pass env, accept"
-${SSH} -F $OBJ/ssh_proxy otherhost \
+_XXX_TEST_A=1 _XXX_TEST_B=2 ${SSH} -F $OBJ/ssh_proxy_envpass otherhost \
sh << 'EOF'
test -z "$_XXX_TEST_A" && test -z "$_XXX_TEST_B"
EOF
@@ -29,8 +36,8 @@ fi
trace "pass single env, accept single env"
verbose "test $tid: pass single env, accept single env"
-_XXX_TEST=blah ${SSH} -oSendEnv="_XXX_TEST" -F $OBJ/ssh_proxy otherhost \
- sh << 'EOF'
+_XXX_TEST=blah ${SSH} -oSendEnv="_XXX_TEST" -F $OBJ/ssh_proxy_envpass \
+ otherhost sh << 'EOF'
test X"$_XXX_TEST" = X"blah"
EOF
r=$?
@@ -41,7 +48,7 @@ fi
trace "pass multiple env, accept multiple env"
verbose "test $tid: pass multiple env, accept multiple env"
_XXX_TEST_A=1 _XXX_TEST_B=2 ${SSH} -oSendEnv="_XXX_TEST_*" \
- -F $OBJ/ssh_proxy otherhost \
+ -F $OBJ/ssh_proxy_envpass otherhost \
sh << 'EOF'
test X"$_XXX_TEST_A" = X"1" -a X"$_XXX_TEST_B" = X"2"
EOF
@@ -49,3 +56,5 @@ r=$?
if [ $r -ne 0 ]; then
fail "environment not found"
fi
+
+rm -f $OBJ/ssh_proxy_envpass