diff options
| author | djm@openbsd.org <djm@openbsd.org> | 2022-01-14 03:32:52 +0000 |
|---|---|---|
| committer | Damien Miller <djm@mindrot.org> | 2022-01-14 14:40:40 +1100 |
| commit | c88265f207dfe0e8bdbaf9f0eda63ed6b33781cf (patch) | |
| tree | 957e95adc61e19b6cef59ffb0b9b4ce90d156e01 /ssh-sk-client.c | |
| parent | 1cd1b2eac39661b849d5a4b4b56363e22bb5f61e (diff) | |
| download | openssh-git-c88265f207dfe0e8bdbaf9f0eda63ed6b33781cf.tar.gz | |
upstream: sshsk_sign: trim call to sshkey_fingerprint()
the resulting fingerprint doesn't appear to be used for anything,
and we end up leaking it.
from Pedro Martelletto; ok dtucker & me
OpenBSD-Commit-ID: 5625cf6c68f082bc2cbbd348e69a3ed731d2f9b7
Diffstat (limited to 'ssh-sk-client.c')
| -rw-r--r-- | ssh-sk-client.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/ssh-sk-client.c b/ssh-sk-client.c index bcef7a5d..7b5752a6 100644 --- a/ssh-sk-client.c +++ b/ssh-sk-client.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ssh-sk-client.c,v 1.10 2021/10/28 02:54:18 djm Exp $ */ +/* $OpenBSD: ssh-sk-client.c,v 1.11 2022/01/14 03:32:52 djm Exp $ */ /* * Copyright (c) 2019 Google LLC * @@ -232,7 +232,6 @@ sshsk_sign(const char *provider, struct sshkey *key, u_int compat, const char *pin) { int oerrno, r = SSH_ERR_INTERNAL_ERROR; - char *fp = NULL; struct sshbuf *kbuf = NULL, *req = NULL, *resp = NULL; *sigp = NULL; @@ -262,12 +261,6 @@ sshsk_sign(const char *provider, struct sshkey *key, goto out; } - if ((fp = sshkey_fingerprint(key, SSH_FP_HASH_DEFAULT, - SSH_FP_DEFAULT)) == NULL) { - error_f("sshkey_fingerprint failed"); - r = SSH_ERR_ALLOC_FAIL; - goto out; - } if ((r = client_converse(req, &resp, SSH_SK_HELPER_SIGN)) != 0) goto out; |