| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
sudo is already run by it, and it breaks if root isn't in sudoers.
OpenBSD-Regress-ID: 6cf22fda32a89c16915f31a6ed9bbdbef2a3bac9
|
|
|
|
|
|
|
|
|
| |
This was due to the sshd logs being written to the wrong log file.
While there, make save_debug_logs less verbose, write the name of the
tarball to regress.log and use $SUDO to remove the old symlinks (which
shouldn't be needed, but won't hurt). Initial problem spotted by anton@.
OpenBSD-Regress-ID: 9c44fb9cd418e6ff31165e7a6c1f9f11a6d19f5b
|
|
|
|
|
|
|
| |
before creating new ones. In -portable some platforms don't like
overwriting existing symlinks.
OpenBSD-Regress-ID: 7e7ddc0beb73e945e1c4c58d51c8a125b518120f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we would log to ssh.log and sshd.log, but that is insufficient
for tests that have more than one concurent ssh/sshd.
Instead, we'll log to separate datestamped files in a $OBJ/log/ and
leave a symlink at the previous location pointing at the most recent
instance with an entry in regress.log showing which files were created
at each point. This should be sufficient to reconstruct what happened
even for tests that use multiple instances of each program. If the test
fails, tar up all of the logs for later analysis.
This will let us also capture the output from some of the other tools
which was previously sent to /dev/null although most of those will be
in future commits.
OpenBSD-Regress-ID: f802aa9e7fa51d1a01225c05fb0412d015c33e24
|
|
|
|
|
| |
This should no longer be needed on Cygwin test runners due to previous
commit.
|
|
|
|
|
| |
On cygwin, the umask might not be sufficient. Should fix tests on
Github runners.
|
|
|
|
|
| |
This fixes tests on platforms that do not have the openssl tool
installed at all.
|
|
|
|
|
|
|
|
| |
commit to add scp to the test sshd's path causes the t-envpass test to fail
when the test scp is given using a fully qualified path. Put this in a
helper function and only call it from the scp tests.
OpenBSD-Regress-ID: 7533dc1c4265c1de716abb062957994195b36df4
|
|
|
|
|
|
|
|
| |
If the scp we're testing is fully qualified (eg it's not in the system
PATH) then add its path to the under-test sshd's PATH so we can find
it. Prompted by bz#3518.
OpenBSD-Regress-ID: 7df4f5a0be3aa135495b7e5a6719d3cbc26cc4c0
|
|
|
|
| |
OpenBSD-Regress-ID: 38783f9676ec348c5a792caecee9a16e354b37b0
|
|
|
|
|
|
|
| |
executable. No-op on most platforms but should prevent warnings in -portable
on systems that don't have 'date %s'.
OpenBSD-Regress-ID: e39d79867b8065e33d0c5926fa1a31f85659d2a4
|
|
|
|
|
|
|
| |
"which" and its behaviour is not standardized, so convert the existing
have_prog function into "which" so we can rely on it being available
and what its semantics are. Add a have_prog wrapper that maintains the
existing behaviour.
|
|
|
|
|
|
|
| |
If set, it is used to cache regress test names that have succeeded and
skip those on a re-run.
OpenBSD-Regress-ID: a7570dd29a58df59f2cca647c3c2ec989b49f247
|
|
|
|
| |
spotted by Corinna Vinschen; feedback & ok dtucker@
|
|
|
|
|
|
|
|
|
| |
Dash (as used by the github runners) has some differences in its trap
builtin:
- it doesn't have -p (which is fine, that's not in posix).
- it doesn't work in a subshell (which turns out to be in compliance
with posix, which means bash isn't).
- it doesn't work in a pipeline, ie "trap|cat" produces no output.
|
|
|
|
|
|
|
|
|
| |
When using Valgrind, we need to wait for all invoked programs to
complete before checking their valgrind logs. Some tests, notably
agent-restrict, set an EXIT trap handler to clean up things like
ssh-agent, but those do not get invoked until test-exec.sh exits.
This causes the Valgrind wait to deadlock, so if present invoke
the EXIT handler before checking the Valgrind logs.
|
|
|
|
| |
agent-restrict now takes care of this itself.
|
| |
|
|
|
|
| |
Found by djm, this should make sorts stable and reduce test flakiness.
|
|
|
|
|
|
|
| |
sshd_config. It defaults to "no", and not explicitly setting it allows us to
enable it for the (optional) hostbased test.
OpenBSD-Regress-ID: aa8e3548eb5793721641d26e56c29f363b767c0c
|
|
|
|
|
|
| |
This will aid in manually reproducing failing commands.
OpenBSD-Regress-ID: b4aba8d5ac5675ceebeeeefa3261ce344e67333a
|
|
|
|
|
| |
The fgrep replacement for buggy greps doesn't work in the sftp-glob test
so move it to just where we know it's needed.
|
|
|
|
|
|
| |
GNU (f)grep <=2.18, as shipped by FreeBSD<=12 and NetBSD<=9 will
occasionally fail to find ssh host keys in the hostkey-rotate test.
If we have those versions, use awk instead.
|
|
|
|
|
|
|
| |
Many tests skip tests for various reasons but not in a consistent way and
don't always clean up, so add that and switch the tests that do that over.
OpenBSD-Regress-ID: 72d2ec90a3ee8849486956a808811734281af735
|
|
|
|
|
|
| |
the implicit 'in "$@"' after 'for i'.
OpenBSD-Regress-ID: 3c9aec6bca4868f85d2742b6ba5223fce110bdbc
|
|
|
|
|
|
| |
This brings the top hunk of the file back in sync with OpenBSD
so patches to the CVS Id should apply instead of always being
rejected.
|
|
|
|
|
|
|
| |
we have to change this and having it in the same hunk as the CVS Id string
means applying changes fails every. single. time.
OpenBSD-Regress-ID: 87cd603eb6db58c9b430bf90adacb7f90864429b
|
|
|
|
|
|
|
|
|
|
| |
scp and sftp like to add -q to the command line passed to ssh which
overrides the LogLevel we set in the config files and suppresses output
to the debug logs so drop any "-q" from the invoked ssh. In the one
case where we actually want to use -q in the banner test, call the ssh
binary directly bypassing the logging wrapper.
OpenBSD-Regress-ID: e2c97d3c964bda33a751374c56f65cdb29755b75
|
|
|
|
|
|
|
|
|
| |
openssl binary with OPENSSL_BIN. This will allow us to use the OPENSSL
variable from mk.conf or the make(1) command line indicating if we're
building with our without OpenSSL, and ultimately get the regress tests
working in the OPENSSL=no configuration.
OpenBSD-Regress-ID: 2d788fade3264d7803e5b54cae8875963f688c4e
|
|
|
|
|
|
| |
permissions warning.
OpenBSD-Regress-ID: 382841db0ee28dfef7f7bffbd511803e1b8ab0ef
|
| |
|
|
|
|
|
|
|
| |
allowing it to be overridden. Do the same in the PuTTY tests since it's
needed there and not exported by test-exec.sh.
OpenBSD-Regress-ID: c49dcd6aa7602a8606b7afa192196ca1fa65de16
|
|
|
|
|
|
|
| |
allows overriding if necessary (eg in -portable where we're testing against a
specific version of OpenSSL).
OpenBSD-Regress-ID: 491f39cae9e762c71aa4bf045803d077139815c5
|
|
|
|
|
|
|
| |
The warn() function is only used in one place in portable and does not
exist upstream. Upgrade the only instance it's used to fail()
(the privsep/sandbox+proxyconnect, from back when that was new) and
remove the now-unused function.
|
|
|
|
|
| |
Reduces diff vs OpenBSD and makes it more likely diffs will apply
cleanly.
|
|
|
|
|
|
|
| |
elapsed time in seconds of each test. This depends on "date +%s" which is
not specified by POSIX but is commonly implemented.
OpenBSD-Regress-ID: ec3c8c19ff49b2192116a0a646ee7c9b944e8a9c
|
|
|
|
|
| |
This groups the portable-specific changes together and makes it a
little more likely that patches will apply cleanly.
|
|
|
|
|
|
| |
moduli file used during the test run.
OpenBSD-Regress-ID: be10f785263120edb64fc87db0e0d6570a10220a
|
|
|
|
|
|
| |
PuTTY interop tests, otherwise skip them.
OpenBSD-Regress-ID: 34565bb50b8aec58331ed02a5e9e0a9a929bef51
|
|
|
|
|
|
| |
Some systems don't have a hostname command (it's not required by POSIX).
The do have uname -n (which is), but as found by tim@ some others (eg
UnixWare) do not report the FQDN from uname -n.
|
| |
|
| |
|
|
|
|
|
|
| |
Use it to create a wrapper function to call it from tests. Fixes the
keygen-comment test on platforms with impoverished default egrep (eg
Solaris).
|
|
|
|
| |
OpenBSD-Regress-ID: 409a7b0e59d1272890fda507651c0c3d2d3c0d89
|
|
|
|
|
|
| |
Jelen
OpenBSD-Regress-ID: 0d9224de3297c7a5f51ba68d6e3725a2a9345fa4
|
|
|
|
|
|
|
| |
multiple tests, and in -portable we use our own local copy to avoid
portability problems.
OpenBSD-Regress-ID: ceb78445fcaac317bec2fc51b3f0d9589048c114
|
|
|
|
| |
OpenBSD-Regress-ID: 339d4cbae224bd8743ffad9c3afb0cf3cb66c357
|
|
|
|
|
|
| |
(ie symlinks, where permissions are not relevant).
OpenBSD-Regress-ID: fb6cfc8b022becb62b2dcb99ed3f072b3326e501
|
|
|
|
| |
OpenBSD-Regress-ID: 4841704ccdee50ee7efc6035bc686695c6ac2991
|
|
|
|
|
|
| |
cleared; with dtucker@
OpenBSD-Regress-ID: 03178a0580324bf0dff28f7eac6c3edbc5407f8e
|