summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Caswell <matt@openssl.org>2022-07-22 14:23:25 +0100
committerMatt Caswell <matt@openssl.org>2022-08-18 16:38:13 +0100
commit1b285ac13726f443d1d737a1e2389ba6e17ba98f (patch)
tree78f69358335d3dea770a4b72255796647faf9abe
parentc77d4556732e2e41e975211498406c777136fbaa (diff)
downloadopenssl-new-1b285ac13726f443d1d737a1e2389ba6e17ba98f.tar.gz
Remove a redundant TODO
If read_ahead data is left over when a record layer closes down, there is already code present to push into the "next" BIO. So the TODO removed here is no longer relevant. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/18132)
-rw-r--r--ssl/record/methods/tls_common.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/ssl/record/methods/tls_common.c b/ssl/record/methods/tls_common.c
index 8b541061ba..4c999c52e8 100644
--- a/ssl/record/methods/tls_common.c
+++ b/ssl/record/methods/tls_common.c
@@ -1080,10 +1080,6 @@ tls_int_new_record_layer(OSSL_LIB_CTX *libctx, const char *propq, int vers,
* that is destined for a higher protection level. To simplify the logic
* we don't support that at this stage.
*/
- /*
- * TODO(RECLAYER): Handle the case of read_ahead at the application
- * level and a key update/reneg occurs.
- */
p = OSSL_PARAM_locate_const(options, OSSL_LIBSSL_RECORD_LAYER_PARAM_READ_AHEAD);
if (p != NULL && !OSSL_PARAM_get_int(p, &rl->read_ahead)) {
RLAYERfatal(rl, SSL_AD_INTERNAL_ERROR, SSL_R_FAILED_TO_GET_PARAMETER);