diff options
| author | Benjamin Kaduk <kaduk@mit.edu> | 2018-07-01 12:49:24 -0500 |
|---|---|---|
| committer | Benjamin Kaduk <kaduk@mit.edu> | 2018-07-01 18:20:11 -0500 |
| commit | 5281bb2252be6575ebb7a8b683e6bd160476fa2a (patch) | |
| tree | 8b1c51b8bd16309bc15f49577968732a4a4a316f /ssl/ssl_txt.c | |
| parent | 8794be2ed8d2e044d8b0135ddb7e903e81335c94 (diff) | |
| download | openssl-new-5281bb2252be6575ebb7a8b683e6bd160476fa2a.tar.gz | |
Address coverity-reported NULL dereference in SSL_SESSION_print()
We need to check the provided SSL_SESSION* for NULL before
attempting to derference it to see if it's a TLS 1.3 session.
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/6622)
Diffstat (limited to 'ssl/ssl_txt.c')
| -rw-r--r-- | ssl/ssl_txt.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ssl/ssl_txt.c b/ssl/ssl_txt.c index 3856491eca..cf6e4c3c05 100644 --- a/ssl/ssl_txt.c +++ b/ssl/ssl_txt.c @@ -33,10 +33,11 @@ int SSL_SESSION_print(BIO *bp, const SSL_SESSION *x) { size_t i; const char *s; - int istls13 = (x->ssl_version == TLS1_3_VERSION); + int istls13; if (x == NULL) goto err; + istls13 = (x->ssl_version == TLS1_3_VERSION); if (BIO_puts(bp, "SSL-Session:\n") <= 0) goto err; s = ssl_protocol_to_string(x->ssl_version); |