diff options
| author | ZhiQiang Fan <aji.zqfan@gmail.com> | 2014-11-21 01:58:45 +0800 |
|---|---|---|
| committer | ZhiQiang Fan <zhiqiang.fan@huawei.com> | 2014-12-26 18:52:55 +0800 |
| commit | d288a28589d3791bc71eee626d1ed0b7ac7bcd23 (patch) | |
| tree | 27eb8164d8ee8e1266fdada36f1425c90836946f /ceilometer/service.py | |
| parent | 86d84a6dbd0369715d49a26fe32b1e0a9087dba5 (diff) | |
| download | ceilometer-d288a28589d3791bc71eee626d1ed0b7ac7bcd23.tar.gz | |
Remove unnecessary import_opt|group
Usually, we should import an option before we use it, otherwise,
NoSuchOpt exception will be raised.
When we import a module, the options in that module are registered,
(or imported), so we don't need to explicitly import them again.
However, it is a bit hard for developers, reviewers and maintainers
to track between files just to check if a specific option is imported
or not. So it is good (not required) whenever we use an option, we import
it explicitly, such kind of redundant is acceptable. But not the case that
we already import a module A, then import_opt|group registered or imported
in that module again, this is obviously unnecessary and should be avoid.
Change-Id: I8672d9f12d862f9a622e5557d9c8dc2fe6717f5e
Closes-Bug: #1389229
Diffstat (limited to 'ceilometer/service.py')
| -rw-r--r-- | ceilometer/service.py | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/ceilometer/service.py b/ceilometer/service.py index 734fa550..21e25e32 100644 --- a/ceilometer/service.py +++ b/ceilometer/service.py @@ -91,9 +91,6 @@ CLI_OPTS = [ ] cfg.CONF.register_cli_opts(CLI_OPTS, group="service_credentials") -cfg.CONF.import_opt('default_log_levels', - 'ceilometer.openstack.common.log') - LOG = log.getLogger(__name__) |