diff options
| author | gord chung <gord@live.ca> | 2016-11-16 23:25:09 +0000 |
|---|---|---|
| committer | Julien Danjou <julien@danjou.info> | 2016-11-17 10:53:49 +0000 |
| commit | 380bb26dbb8aec89ea853d8afd435c213fd72b0c (patch) | |
| tree | 31f3a0c4a08a6cc8012b2eacb14adc494468d7fe /requirements.txt | |
| parent | 9181d7494d7c36dad3ae5b78f2d907e1a5c180eb (diff) | |
| download | ceilometer-380bb26dbb8aec89ea853d8afd435c213fd72b0c.tar.gz | |
Replace retrying with tenacity
We are replacing all usages of the 'retrying' package with
'tenacity' as the author of retrying is not actively maintaining
the project. Tenacity is a fork of retrying, but has improved the
interface and extensibility (see [1] for more details). Our end
goal here is removing the retrying package from our requirements.
Tenacity provides the same functionality as retrying, but has the
following major differences to account for:
- tenacity uses seconds rather than ms as retrying did.
- tenacity has different kwargs for the decorator and
Retrying class itself.
- tenacity has a different approach for retrying args by
using classes for its stop/wait/retry kwargs.
- By default tenacity raises a RetryError if a retried callable
times out; retrying raises the last exception from the callable.
Tenacity provides backwards compatibility here by offering
the 'reraise' kwarg.
- tenacity defines 'time.sleep' as a default value for a kwarg.
That said consumers who need to mock patch time.sleep
need to account for this via mocking of time.sleep before
tenacity is imported.
This patch updates all usages of retrying with tenacity.
Unit tests will be added where applicable.
Note: This change is not newton critical so projects are welcome
to hold off on committing until post-newton. Ideally this change
will merge by the first part of Ocata so dependant functionality
can land and have time to solidify for Ocata.
[1] https://github.com/jd/tenacity
Closes-Bug: #1635394
Change-Id: I0ad7deee3f17f6626708369371167184a40e6368
Diffstat (limited to 'requirements.txt')
| -rw-r--r-- | requirements.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/requirements.txt b/requirements.txt index 14af4b6e..e2ed5f0f 100644 --- a/requirements.txt +++ b/requirements.txt @@ -6,7 +6,7 @@ cotyledon>=1.2.4 #Apache-2.0 futures>=3.0;python_version=='2.7' or python_version=='2.6' # BSD futurist>=0.11.0 # Apache-2.0 debtcollector>=1.2.0 # Apache-2.0 -retrying!=1.3.0,>=1.2.3 # Apache-2.0 +tenacity>=3.1.0 # Apache-2.0 jsonpath-rw-ext>=0.1.9 # Apache-2.0 jsonschema!=2.5.0,<3.0.0,>=2.0.0 # MIT kafka-python>=1.3.1 # Apache-2.0 |