diff options
| author | Mohammed Naser <mnaser@vexxhost.com> | 2023-02-19 18:47:11 +0000 |
|---|---|---|
| committer | Mohammed Naser <mnaser@vexxhost.com> | 2023-03-22 19:09:48 +0000 |
| commit | a327842a25f904397be0c3c141ada1f9ac8050cd (patch) | |
| tree | e17cedc26ef3692702801c97f07fe3b58a04c16d | |
| parent | d4b73ed1c415da84db2a67f2d24f465b604e1359 (diff) | |
| download | horizon-a327842a25f904397be0c3c141ada1f9ac8050cd.tar.gz | |
fix(swift): allow object creation
It is currently not possible to create any new objects inside
Swift as you'd always get an error that the new object name
already exists all the time.
This fixes that issue and enables you to upload files again.
Closes-Bug: #1993005
Related-Change-Id: Idfb90a327e94ccaa3263aaaad1d6d52fa46312f4
Change-Id: Ib2f1aaae87820e8d5c4a6c9b01b6a6e9a5552952
| -rw-r--r-- | openstack_dashboard/static/app/core/openstack-service-api/swift.service.js | 3 | ||||
| -rw-r--r-- | openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js | 1 |
2 files changed, 1 insertions, 3 deletions
diff --git a/openstack_dashboard/static/app/core/openstack-service-api/swift.service.js b/openstack_dashboard/static/app/core/openstack-service-api/swift.service.js index b2b170efe..daafd8ead 100644 --- a/openstack_dashboard/static/app/core/openstack-service-api/swift.service.js +++ b/openstack_dashboard/static/app/core/openstack-service-api/swift.service.js @@ -296,8 +296,7 @@ service.getObjectURL(container, objectName, 'metadata') ); if (ignoreError) { - // provide a noop error handler so the error is ignored - return promise.catch(angular.noop); + return promise; } return promise.catch(function onError() { toastService.add('error', gettext('Unable to get details of the object.')); diff --git a/openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js b/openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js index 40ec0002d..06a64908d 100644 --- a/openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js +++ b/openstack_dashboard/static/app/core/openstack-service-api/swift.service.spec.js @@ -256,7 +256,6 @@ spyOn(promise, 'catch'); spyOn(toastService, 'add'); service.getObjectDetails('spam', 'ham', true); - expect(promise.catch).toHaveBeenCalledWith(angular.noop); expect(toastService.add).not.toHaveBeenCalled(); }); |